Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7354)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 11052015: Fix bug with login-prompt-visible not being sent in some rare cases. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: build Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/login/screen_gaia_signin.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index 6a7833ec5f780ba6527b23e474ace9328104747e..cbdcc8ac3e62f6970a1d48344fc4c2bcd538280f 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -1009,6 +1009,7 @@ void SigninScreenHandler::SendUserList(bool animated) {
void SigninScreenHandler::HandleAccountPickerReady(
const base::ListValue* args) {
+ LOG(INFO) << "Login WebUI >> AccountPickerReady";
PrefService* prefs = g_browser_process->local_state();
if (prefs->GetBoolean(prefs::kFactoryResetRequested)) {
@@ -1139,8 +1140,14 @@ void SigninScreenHandler::HandleOpenProxySettings(const base::ListValue* args) {
}
void SigninScreenHandler::HandleLoginVisible(const base::ListValue* args) {
- LOG(INFO) << "Login WebUI >> LoginVisible, webui_visible_: "
- << webui_visible_;
+ std::string source;
+ if (!args->GetString(0, &source)) {
+ NOTREACHED();
+ return;
+ }
+
+ LOG(INFO) << "Login WebUI >> LoginVisible, source: " << source
+ << ", webui_visible_: " << webui_visible_;
if (!webui_visible_) {
// There might be multiple messages from OOBE UI so send notifications after
// the first one only.
« no previous file with comments | « chrome/browser/resources/chromeos/login/screen_gaia_signin.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698