Native Messaging revert-revert

Native Messaging revert-revert

Native messaging was reverted in
https://chromiumcodereview.appspot.com/10990064 because it breaks some
extensions: http://code.google.com/p/chromium/issues/detail?id=143503

Original Review URL: https://codereview.chromium.org/10818013

TBR=jam@chromium.org
(already be lgtm'd before revert)

BUG=142915, 143503
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162790

[Matt Perry, 2012-10-16 18:47:52]

Could you point out how this differs from the original CL?

[eaugusti, 2012-10-16 19:52:05]

https://codereview.chromium.org/11048047/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/messaging/message_service.cc (right):

https://codereview.chromium.org/11048047/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/messaging/message_service.cc:450: opener_process
!= receiver_process;
This was the line that caused the bug. In the original CL, this was a '=='.
Which means that only message channels with the same RenderProcessHost were
notified.

https://codereview.chromium.org/11048047/diff/1/chrome/renderer/resources/ext...
File chrome/renderer/resources/extensions/miscellaneous_bindings.js (right):

https://codereview.chromium.org/11048047/diff/1/chrome/renderer/resources/ext...
chrome/renderer/resources/extensions/miscellaneous_bindings.js:264: if
(port.name == chromeHidden.kMessageChannel && !responseCallback) {
This line was also an unnecessary change in the original CL.
It was changed to an logical equivalent, but still quite unnecessary.

[Matt Perry, 2012-10-16 22:24:58]

Thanks for fixing this! LGTM

[commit-bot: I haz the power, 2012-10-18 19:04:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eaugusti@chromium.org/11048047/1

[commit-bot: I haz the power, 2012-10-18 21:18:19]

Change committed as 162790