Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 11048039: Don't use web intents for rss feeds. (Closed)

Created:
8 years, 2 months ago by Greg Billock
Modified:
8 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, rdsmith+dwatch_chromium.org, asanka
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 1 4 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/buffered_resource_handler.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/base/mime_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Greg Billock
8 years, 2 months ago (2012-10-11 23:06:27 UTC) #1
James Hawkins
LGTM pending try jobs.
8 years, 2 months ago (2012-10-11 23:08:02 UTC) #2
Greg Billock
On 2012/10/11 23:08:02, James Hawkins wrote: > LGTM pending try jobs. can I get owners ...
8 years, 2 months ago (2012-10-11 23:12:43 UTC) #3
Paweł Hajdan Jr.
chrome/browser/download LGTM
8 years, 2 months ago (2012-10-11 23:35:08 UTC) #4
Greg Billock
On 2012/10/11 23:35:08, Paweł Hajdan Jr. wrote: > chrome/browser/download LGTM Scott, Will, can you lgtm ...
8 years, 2 months ago (2012-10-11 23:37:52 UTC) #5
willchan no longer on Chromium
Seems fine, but why not rss? Is there an explanation somewhere?
8 years, 2 months ago (2012-10-11 23:53:30 UTC) #6
willchan no longer on Chromium
Also we should figure out how to proceed in the future so y'all don't have ...
8 years, 2 months ago (2012-10-11 23:54:19 UTC) #7
sky
LGTM
8 years, 2 months ago (2012-10-11 23:57:37 UTC) #8
Greg Billock
On 2012/10/11 23:54:19, willchan wrote: > Also we should figure out how to proceed in ...
8 years, 2 months ago (2012-10-12 00:04:54 UTC) #9
willchan no longer on Chromium
OK, LGTM On Thu, Oct 11, 2012 at 5:04 PM, <gbillock@chromium.org> wrote: > On 2012/10/11 ...
8 years, 2 months ago (2012-10-12 16:41:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/11048039/2003
8 years, 2 months ago (2012-10-12 16:49:43 UTC) #11
Greg Billock
On 2012/10/12 16:49:43, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
8 years, 2 months ago (2012-10-12 21:55:19 UTC) #12
asanka
LGTM
8 years, 2 months ago (2012-10-12 22:46:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/11048039/2003
8 years, 2 months ago (2012-10-12 23:37:33 UTC) #14
commit-bot: I haz the power
8 years, 2 months ago (2012-10-12 23:40:07 UTC) #15
Change committed as 161675

Powered by Google App Engine
This is Rietveld 408576698