Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/download/chrome_download_manager_delegate_unittest.cc

Issue 11048039: Don't use web intents for rss feeds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/chrome_download_manager_delegate_unittest.cc
diff --git a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
index 66049b227c3e72e6c22b5f02841f0c04b5792aeb..a0fcadae67539fc1f8f9965c5d990a45d9b19c71 100644
--- a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
+++ b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
@@ -911,6 +911,7 @@ TEST_F(ChromeDownloadManagerDelegateTest, StartDownload_LastSavePath) {
RunTestCases(kLastSavePathTestCases, 1);
}
+#if defined(OS_CHROMEOS)
TEST_F(ChromeDownloadManagerDelegateTest, StartDownload_WebIntents) {
const DownloadTestCase kWebIntentsTestCases[] = {
{
@@ -919,7 +920,7 @@ TEST_F(ChromeDownloadManagerDelegateTest, StartDownload_WebIntents) {
// .webintents extension).
AUTOMATIC,
content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
- "http://example.com/feed.exe", "application/rss+xml",
+ "http://example.com/feed.exe", "application/msword",
FILE_PATH_LITERAL(""),
FILE_PATH_LITERAL("feed.exe.webintents"),
@@ -933,7 +934,7 @@ TEST_F(ChromeDownloadManagerDelegateTest, StartDownload_WebIntents) {
// 2: A download with a forced path won't be handled by web intents.
FORCED,
content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
- "http://example.com/feed.exe", "application/rss+xml",
+ "http://example.com/feed.exe", "application/msword",
FILE_PATH_LITERAL("forced.feed.exe"),
FILE_PATH_LITERAL("forced.feed.exe"),
@@ -946,6 +947,7 @@ TEST_F(ChromeDownloadManagerDelegateTest, StartDownload_WebIntents) {
RunTestCases(kWebIntentsTestCases, arraysize(kWebIntentsTestCases));
}
+#endif
// TODO(asanka): Add more tests.
// * Default download path is not writable.

Powered by Google App Engine
This is Rietveld 408576698