ReadPixels from known-usable textures, and give SkBitmap its precious BGRA.

ReadPixels from known-usable textures, and give SkBitmap its precious BGRA.

BUG=153094
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159842

[Ami GONE FROM CHROMIUM, 2012-10-02 18:14:50]

piman: please review.

(pro-tip: don't test BGR/RGB sensitivity on videos that have a lead-in that's
mostly _green_, such as MPAA ratings...)

[piman, 2012-10-02 19:38:50]

https://chromiumcodereview.appspot.com/11043002/diff/1/content/renderer/media...
File content/renderer/media/renderer_gpu_video_decoder_factories.cc (right):

https://chromiumcodereview.appspot.com/11043002/diff/1/content/renderer/media...
content/renderer/media/renderer_gpu_video_decoder_factories.cc:197:
GL_UNSIGNED_BYTE, pixels);
Shouldn't that be fixed in the GPU process? It looks wrong - if you ask one
format you shouldn't get pixels in the other format.

[Ami GONE FROM CHROMIUM, 2012-10-02 19:49:23]

https://chromiumcodereview.appspot.com/11043002/diff/1/content/renderer/media...
File content/renderer/media/renderer_gpu_video_decoder_factories.cc (right):

https://chromiumcodereview.appspot.com/11043002/diff/1/content/renderer/media...
content/renderer/media/renderer_gpu_video_decoder_factories.cc:197:
GL_UNSIGNED_BYTE, pixels);
On 2012/10/02 19:38:50, piman wrote:
> Shouldn't that be fixed in the GPU process? It looks wrong - if you ask one
> format you shouldn't get pixels in the other format.

Agreed with the "should" there, but not sure how.

DXVA fails to create textures if I ask for RGBA instead of BGRA (and, helpfully
enough, D3D_FORMAT reverses the pixel order for its constant naming...).

I can't change the GL_RGBA in CreateTextures to GL_BGRA_EXT b/c other decoders
really do do RGBA.  

Suggestions?

[piman, 2012-10-02 22:27:57]

lgtm

[commit-bot: I haz the power, 2012-10-02 22:29:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/11043002/5001

[piman, 2012-10-02 23:29:17]

lgtm

[commit-bot: I haz the power, 2012-10-02 23:29:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/11043002/4

[commit-bot: I haz the power, 2012-10-03 05:50:30]

Change committed as 159842