Upstreaming chrome/common/chrome_* diff.

Upstreaming chrome/common/chrome_* diff.

Upstreaming chrome/common/chrome_* diff for Android.

BUG=152827
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159777

[aurimas (slooooooooow), 2012-10-01 20:30:03]

Hey Nilesh and Yaron,

Could you take a look at my CL please?

Thanks,
Aurimas

[Yaron, 2012-10-01 20:38:04]

removing myself. Nilesh is a better reviewer for this

[nilesh, 2012-10-01 20:38:35]

Mostly nits.

https://codereview.chromium.org/11031008/diff/1/base/android/path_utils.h
File base/android/path_utils.h (right):

https://codereview.chromium.org/11031008/diff/1/base/android/path_utils.h#new...
base/android/path_utils.h:9: #include <string>
Remove the include.

https://codereview.chromium.org/11031008/diff/1/base/android/path_utils.h#new...
base/android/path_utils.h:16: // Return the absolute path to the data directory
of the current application.
Please update the comment. Something like:
"Retrieves the absolute path...."
The result is placed in the FilePath pointed to by 'result'

https://codereview.chromium.org/11031008/diff/1/base/android/path_utils_unitt...
File base/android/path_utils_unittest.cc (right):

https://codereview.chromium.org/11031008/diff/1/base/android/path_utils_unitt...
base/android/path_utils_unittest.cc:9: #include "base/file_path.h"
Sort order.

[aurimas (slooooooooow), 2012-10-01 21:06:41]

Hello William,

Could you take a look at this CL?

Thanks!
Aurimas

https://codereview.chromium.org/11031008/diff/1/base/android/path_utils.h
File base/android/path_utils.h (right):

https://codereview.chromium.org/11031008/diff/1/base/android/path_utils.h#new...
base/android/path_utils.h:9: #include <string>
On 2012/10/01 20:38:35, nileshagrawal1 wrote:
> Remove the include.

Done.

https://codereview.chromium.org/11031008/diff/1/base/android/path_utils.h#new...
base/android/path_utils.h:16: // Return the absolute path to the data directory
of the current application.
On 2012/10/01 20:38:35, nileshagrawal1 wrote:
> Please update the comment. Something like:
> "Retrieves the absolute path...."
> The result is placed in the FilePath pointed to by 'result'

Done.

https://codereview.chromium.org/11031008/diff/1/base/android/path_utils_unitt...
File base/android/path_utils_unittest.cc (right):

https://codereview.chromium.org/11031008/diff/1/base/android/path_utils_unitt...
base/android/path_utils_unittest.cc:9: #include "base/file_path.h"
On 2012/10/01 20:38:35, nileshagrawal1 wrote:
> Sort order.

Done.

[willchan no longer on Chromium, 2012-10-02 02:21:19]

Sorry, chrome networking offsite for the week. Find another reviewer?


On Mon, Oct 1, 2012 at 2:06 PM, <aurimas@chromium.org> wrote:

> Hello William,
>
> Could you take a look at this CL?
>
> Thanks!
> Aurimas
>
>
>
> https://codereview.chromium.**org/11031008/diff/1/base/**
>
android/path_utils.h<https://codereview.chromium.org/11031008/diff/1/base/android/path_utils.h>
> File base/android/path_utils.h (right):
>
> https://codereview.chromium.**org/11031008/diff/1/base/**
>
android/path_utils.h#newcode9<https://codereview.chromium.org/11031008/diff/1/base/android/path_utils.h#newcode9>
> base/android/path_utils.h:9: #include <string>
> On 2012/10/01 20:38:35, nileshagrawal1 wrote:
>
>> Remove the include.
>>
>
> Done.
>
>
> https://codereview.chromium.**org/11031008/diff/1/base/**
>
android/path_utils.h#newcode16<https://codereview.chromium.org/11031008/diff/1/base/android/path_utils.h#newcode16>
> base/android/path_utils.h:16: // Return the absolute path to the data
> directory of the current application.
> On 2012/10/01 20:38:35, nileshagrawal1 wrote:
>
>> Please update the comment. Something like:
>> "Retrieves the absolute path...."
>> The result is placed in the FilePath pointed to by 'result'
>>
>
> Done.
>
>
> https://codereview.chromium.**org/11031008/diff/1/base/**
>
android/path_utils_unittest.cc<https://codereview.chromium.org/11031008/diff/1/base/android/path_utils_unittest.cc>
> File base/android/path_utils_**unittest.cc (right):
>
> https://codereview.chromium.**org/11031008/diff/1/base/**
>
android/path_utils_unittest.**cc#newcode9<https://codereview.chromium.org/11031008/diff/1/base/android/path_utils_unittest.cc#newcode9>
> base/android/path_utils_**unittest.cc:9: #include "base/file_path.h"
> On 2012/10/01 20:38:35, nileshagrawal1 wrote:
>
>> Sort order.
>>
>
> Done.
>
>
https://codereview.chromium.**org/11031008/<https://codereview.chromium.org/1...
>

[aurimas (slooooooooow), 2012-10-02 04:04:03]

Hello Brett,

Could you take a look at this CL?

Thanks,
Aurimas

[brettw, 2012-10-02 18:29:23]

lgtm

[commit-bot: I haz the power, 2012-10-02 18:37:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/11031008/11001

[commit-bot: I haz the power, 2012-10-02 22:03:35]

Change committed as 159777