Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: base/test/test_support_android.cc

Issue 11031008: Upstreaming chrome/common/chrome_* diff. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixing Nishel's nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base_paths_android.cc ('k') | chrome/common/chrome_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/test_support_android.cc
diff --git a/base/test/test_support_android.cc b/base/test/test_support_android.cc
index db44cace0b8642970c583757f9caf9e62bb91634..8b512f46d725cbc3e3ba4a7dcbaf5178381bfb8f 100644
--- a/base/test/test_support_android.cc
+++ b/base/test/test_support_android.cc
@@ -142,13 +142,11 @@ base::MessagePump* CreateMessagePumpForUIStub() {
bool GetTestProviderPath(int key, FilePath* result) {
switch (key) {
case base::DIR_MODULE: {
- *result = FilePath(base::android::GetExternalStorageDirectory());
- return true;
+ return base::android::GetExternalStorageDirectory(result);
}
case base::DIR_ANDROID_APP_DATA: {
// For tests, app data is put in external storage.
- *result = FilePath(base::android::GetExternalStorageDirectory());
- return true;
+ return base::android::GetExternalStorageDirectory(result);
}
default:
return false;
« no previous file with comments | « base/base_paths_android.cc ('k') | chrome/common/chrome_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698