Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 11029045: Fix crash when a download is requested for an outdated plugin. (Closed)

Created:
8 years, 2 months ago by ibraaaa
Modified:
8 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix crash when a download is requested for an outdated plugin. BUG=154167 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160403

Patch Set 1 #

Total comments: 4

Patch Set 2 : .. #

Patch Set 3 : baureb@ #

Patch Set 4 : bauerb@ #

Total comments: 1

Patch Set 5 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M chrome/browser/plugins/plugin_infobar_delegates.cc View 1 2 3 4 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/browser/plugins/plugin_installer.h View 1 2 3 1 chunk +4 lines, -9 lines 0 comments Download
M chrome/browser/plugins/plugin_installer.cc View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ibraaaa
Please have a look. Thanks. http://codereview.chromium.org/11029045/diff/1/chrome/browser/plugins/plugin_installer.cc File chrome/browser/plugins/plugin_installer.cc (right): http://codereview.chromium.org/11029045/diff/1/chrome/browser/plugins/plugin_installer.cc#newcode175 chrome/browser/plugins/plugin_installer.cc:175: void PluginInstaller::OpenDownloadURL(GURL plugin_url, Here ...
8 years, 2 months ago (2012-10-05 11:14:07 UTC) #1
Bernhard Bauer
http://codereview.chromium.org/11029045/diff/1/chrome/browser/plugins/plugin_installer.cc File chrome/browser/plugins/plugin_installer.cc (right): http://codereview.chromium.org/11029045/diff/1/chrome/browser/plugins/plugin_installer.cc#newcode175 chrome/browser/plugins/plugin_installer.cc:175: void PluginInstaller::OpenDownloadURL(GURL plugin_url, On 2012/10/05 11:14:07, ibraaaa wrote: > ...
8 years, 2 months ago (2012-10-05 11:16:30 UTC) #2
ibraaaa
http://codereview.chromium.org/11029045/diff/1/chrome/browser/plugins/plugin_installer.cc File chrome/browser/plugins/plugin_installer.cc (right): http://codereview.chromium.org/11029045/diff/1/chrome/browser/plugins/plugin_installer.cc#newcode175 chrome/browser/plugins/plugin_installer.cc:175: void PluginInstaller::OpenDownloadURL(GURL plugin_url, Well I thought this way. If ...
8 years, 2 months ago (2012-10-05 11:23:36 UTC) #3
Bernhard Bauer
http://codereview.chromium.org/11029045/diff/1/chrome/browser/plugins/plugin_installer.cc File chrome/browser/plugins/plugin_installer.cc (right): http://codereview.chromium.org/11029045/diff/1/chrome/browser/plugins/plugin_installer.cc#newcode175 chrome/browser/plugins/plugin_installer.cc:175: void PluginInstaller::OpenDownloadURL(GURL plugin_url, On 2012/10/05 11:23:36, ibraaaa wrote: > ...
8 years, 2 months ago (2012-10-05 12:01:56 UTC) #4
ibraaaa
8 years, 2 months ago (2012-10-05 13:31:02 UTC) #5
Bernhard Bauer
LGTM with a nit: http://codereview.chromium.org/11029045/diff/4005/chrome/browser/plugins/plugin_infobar_delegates.cc File chrome/browser/plugins/plugin_infobar_delegates.cc (right): http://codereview.chromium.org/11029045/diff/4005/chrome/browser/plugins/plugin_infobar_delegates.cc#newcode237 chrome/browser/plugins/plugin_infobar_delegates.cc:237: // result in killing ourselves. ...
8 years, 2 months ago (2012-10-05 14:22:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@google.com/11029045/3002
8 years, 2 months ago (2012-10-05 14:26:45 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-05 17:07:38 UTC) #8
Change committed as 160403

Powered by Google App Engine
This is Rietveld 408576698