Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2066)

Unified Diff: chrome/browser/plugins/plugin_installer.h

Issue 11029045: Fix crash when a download is requested for an outdated plugin. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: nit Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugins/plugin_infobar_delegates.cc ('k') | chrome/browser/plugins/plugin_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/plugin_installer.h
diff --git a/chrome/browser/plugins/plugin_installer.h b/chrome/browser/plugins/plugin_installer.h
index 8dca3fd7c29d53d4181a83c21a1c850c479993a7..388f861ea3c54d53c4f501bcb63c6d37c8a42336 100644
--- a/chrome/browser/plugins/plugin_installer.h
+++ b/chrome/browser/plugins/plugin_installer.h
@@ -48,18 +48,13 @@ class PluginInstaller : public content::DownloadItem::Observer {
InstallerState state() const { return state_; }
- // Opens the download URL in a new tab. This method should only be called if
- // |url_for_display| returns true.
- void OpenDownloadURL(bool url_for_display,
- const GURL& plugin_url,
+ // Opens the download URL in a new tab.
+ void OpenDownloadURL(const GURL& plugin_url,
content::WebContents* web_contents);
// Starts downloading the download URL and opens the downloaded file
- // when finished. This method should only be called if |url_for_display|
- // returns false.
- void StartInstalling(bool url_for_display,
- const GURL& plugin_url,
- TabContents* tab_contents);
+ // when finished.
+ void StartInstalling(const GURL& plugin_url, TabContents* tab_contents);
private:
void DownloadStarted(scoped_refptr<content::DownloadManager> dlm,
« no previous file with comments | « chrome/browser/plugins/plugin_infobar_delegates.cc ('k') | chrome/browser/plugins/plugin_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698