Issue 11028150: - Add a script which touches the tools/VERSION file to ensure

Issue 11028150: - Add a script which touches the tools/VERSION file to ensure (Closed)

Created:
8 years, 2 months ago by Ivan Posva

Modified:
8 years, 2 months ago

Reviewers:
ricow1, siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/tools/

Visibility:
Public.

More Reviews

Description

- Add a script which touches the tools/VERSION file to ensure version.cc and others will be rebuild. Committed: https://code.google.com/p/dart/source/detail?r=13586

Patch Set 2 : #

Total comments: 6

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	A	touch_version.py	View	1	1 chunk	+18 lines, -0 lines	6 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Once this has landed I will update the DEPS files. -Ivan

8 years, 2 months ago (2012-10-11 20:44:03 UTC) #1

siva

lgtm https://chromiumcodereview.appspot.com/11028150/diff/2001/touch_version.py File touch_version.py (right): https://chromiumcodereview.appspot.com/11028150/diff/2001/touch_version.py#newcode1 touch_version.py:1: # Copyright (c) 2011, the Dart project authors. ...

8 years, 2 months ago (2012-10-11 20:51:47 UTC) #2

Ivan Posva

https://chromiumcodereview.appspot.com/11028150/diff/2001/touch_version.py File touch_version.py (right): https://chromiumcodereview.appspot.com/11028150/diff/2001/touch_version.py#newcode1 touch_version.py:1: # Copyright (c) 2011, the Dart project authors. Please ...

8 years, 2 months ago (2012-10-11 22:16:15 UTC) #3

ricow1

LGTM https://chromiumcodereview.appspot.com/11028150/diff/2001/touch_version.py File touch_version.py (right): https://chromiumcodereview.appspot.com/11028150/diff/2001/touch_version.py#newcode10 touch_version.py:10: # Change into the dart directory as we ...

8 years, 2 months ago (2012-10-12 05:51:12 UTC) #4

Ivan Posva

https://chromiumcodereview.appspot.com/11028150/diff/2001/touch_version.py File touch_version.py (right): https://chromiumcodereview.appspot.com/11028150/diff/2001/touch_version.py#newcode12 touch_version.py:12: runtime_src = os.path.join(os.path.dirname(sys.argv[0]), os.pardir) On 2012/10/12 05:51:12, ricow1 wrote: ...

8 years, 2 months ago (2012-10-12 05:55:19 UTC) #5

ricow1

8 years, 2 months ago (2012-10-12 05:57:53 UTC) #6

https://chromiumcodereview.appspot.com/11028150/diff/2001/touch_version.py
File touch_version.py (right):

https://chromiumcodereview.appspot.com/11028150/diff/2001/touch_version.py#ne...
touch_version.py:12: runtime_src = os.path.join(os.path.dirname(sys.argv[0]),
os.pardir)
On 2012/10/12 05:55:19, Ivan Posva wrote:
> On 2012/10/12 05:51:12, ricow1 wrote:
> > the version file is right next to this right, so you could just do:
> > tools = os.path.dirname(os.path.realpath(__file__))
> > os.utime(os.path.join('tools', 'VERSION'), None)
> Probably without the quotes around tools? I'll try that.
Ah, yes, sorry

Expand Messages | Collapse Messages