Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: remoting/host/desktop_environment_factory.h

Issue 11028128: [Chromoting] Request the daemon to open a terminal once a connection has been accepted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feeback and rebased on top of https://chromiumcodereview.appspot.com/11017065/ Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/desktop_environment_factory.h
diff --git a/remoting/host/desktop_environment_factory.h b/remoting/host/desktop_environment_factory.h
index 9bbd71c165699b77b0a5dea19463ea700a3eba4e..1f89967f9bad1259cb0fd5dd873ff27306f938df 100644
--- a/remoting/host/desktop_environment_factory.h
+++ b/remoting/host/desktop_environment_factory.h
@@ -15,6 +15,7 @@ class SingleThreadTaskRunner;
namespace remoting {
+class ChromotingHost;
class DesktopEnvironment;
class DesktopEnvironmentFactory {
@@ -24,7 +25,9 @@ class DesktopEnvironmentFactory {
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner);
virtual ~DesktopEnvironmentFactory();
- virtual scoped_ptr<DesktopEnvironment> Create();
+ // Creates an instance of |DesktopEnvironment| to be used by |host|.
+ virtual scoped_ptr<DesktopEnvironment> Create(
+ scoped_refptr<ChromotingHost> host);
Wez 2012/10/17 17:51:57 Since DesktopEnvironments are created per-client,
Wez 2012/10/17 17:51:57 If you really need to pass the |host| here then pa
alexeypa (please no reviews) 2012/10/17 21:35:53 Done.
alexeypa (please no reviews) 2012/10/17 21:35:53 Ack.
Wez 2012/10/17 22:04:24 The more I think about it, the more I think I'd pr
// Returns |true| if created |DesktopEnvironment| instances support audio
// capture.

Powered by Google App Engine
This is Rietveld 408576698