[Chromoting] Request the daemon to open a terminal once a connection has been accepted.

remoting/host/desktop_environment_factory.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_DESKTOP_ENVIRONMENT_FACTORY_H_
 #define REMOTING_HOST_DESKTOP_ENVIRONMENT_FACTORY_H_
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 
 namespace base {
 class SingleThreadTaskRunner;
 }  // namespace base
 
 namespace remoting {
 
+class ChromotingHost;
 class DesktopEnvironment;
 
 class DesktopEnvironmentFactory {
  public:
   DesktopEnvironmentFactory(
       scoped_refptr<base::SingleThreadTaskRunner> input_task_runner,
       scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner);
   virtual ~DesktopEnvironmentFactory();
 
-  virtual scoped_ptr<DesktopEnvironment> Create();
+  // Creates an instance of |DesktopEnvironment| to be used by |host|.
+  virtual scoped_ptr<DesktopEnvironment> Create(
+      scoped_refptr<ChromotingHost> host);

[Wez, 2012/10/17 17:51:57]

Since DesktopEnvironments are created per-client, why not pass the client here?
:)

[Wez, 2012/10/17 17:51:57]

If you really need to pass the |host| here then pass it to the factory-specific
ctor, rather than to the Create() method.

[alexeypa (please no reviews), 2012/10/17 21:35:53]

Done.

[alexeypa (please no reviews), 2012/10/17 21:35:53]

Ack.

[Wez, 2012/10/17 22:04:24]

The more I think about it, the more I think I'd prefer that you pass the
ChromotingHost to the factory-specific ctor, but arguably this approach is more
future-proof.

 
   // Returns |true| if created |DesktopEnvironment| instances support audio
   // capture.
   virtual bool SupportsAudioCapture() const;
 
  protected:
   scoped_refptr<base::SingleThreadTaskRunner> input_task_runner_;
   scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(DesktopEnvironmentFactory);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_DESKTOP_ENVIRONMENT_FACTORY_H_