Implicit coversion operators from integer geometry types to floating point.

Implicit coversion operators from integer geometry types to floating point.

This change allows you to call a function that expects a floating point
object with an integer object and have things just work. The addition
operator for Points is outside the Point classes so it can add/subtract integer
and float points together implicitly.

Tested to verify compilation with:
ui_unittests:RectTest.ToRectF
ui_unittests:SizeTest.ToSizeF
ui_unittests:PointTest.ToPointF

BUG=147395
R=sky@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161415

[danakj, 2012-10-10 22:13:24]

TBH I'm not sure about operator==. I tried to keep this conservative for now.

Since it would be comparing both as floats, maybe it makes sense to just allow
(a == b) where each can be integer or float.

[Peter Kasting, 2012-10-10 22:13:50]

On 2012/10/10 22:13:24, danakj wrote:
> Since it would be comparing both as floats, maybe it makes sense to just allow
> (a == b) where each can be integer or float.

Makes sense to me.

[danakj, 2012-10-10 22:22:03]

On 2012/10/10 22:13:50, Peter Kasting wrote:
> On 2012/10/10 22:13:24, danakj wrote:
> > Since it would be comparing both as floats, maybe it makes sense to just
allow
> > (a == b) where each can be integer or float.
> 
> Makes sense to me.

Thanks, I also convinced myself of this. It would make a situation where Int ==
Float would fail, but Float == Int would work.

New patch moves operator== outside the classes so that it works with int and
float more consistently.

[tfarina, 2012-10-11 00:03:56]

On 2012/10/10 22:22:03, danakj wrote:
> New patch moves operator== outside the classes so that it works with int and
> float more consistently.

If you moved it outside, please update the CL description, because it reads "The
operator== remains inside each class".

[danakj, 2012-10-11 00:05:08]

On Wed, Oct 10, 2012 at 5:03 PM,  <tfarina@chromium.org> wrote:
> If you moved it outside, please update the CL description, because it reads
> "The
> operator== remains inside each class".

Thanks :)

[sky, 2012-10-11 00:55:13]

LGTM

http://codereview.chromium.org/11028127/diff/3004/ui/ui_unittests.gypi
File ui/ui_unittests.gypi (right):

http://codereview.chromium.org/11028127/diff/3004/ui/ui_unittests.gypi#newcode85
ui/ui_unittests.gypi:85: 'gfx/size_unittest.cc',
sort

[danakj, 2012-10-11 01:10:09]

Thanks!

http://codereview.chromium.org/11028127/diff/3004/ui/ui_unittests.gypi
File ui/ui_unittests.gypi (right):

http://codereview.chromium.org/11028127/diff/3004/ui/ui_unittests.gypi#newcode85
ui/ui_unittests.gypi:85: 'gfx/size_unittest.cc',
On 2012/10/11 00:55:13, sky wrote:
> sort

Done.

[commit-bot: I haz the power, 2012-10-11 06:01:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11028127/6010

[commit-bot: I haz the power, 2012-10-11 06:01:40]

Presubmit check for 11028127-6010 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    webkit/plugins
    webkit/plugins/ppapi
    content/renderer

Presubmit checks took 1.7s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[danakj, 2012-10-11 06:03:40]

+piman for content/ OWNERS
+jamesr for webkit/ OWNERS

[jamesr, 2012-10-11 18:02:15]

webkit/ and content/renderer lgtm

[commit-bot: I haz the power, 2012-10-11 18:03:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11028127/6010

[commit-bot: I haz the power, 2012-10-11 18:03:28]

Failed to apply patch for ui/ui_unittests.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ui/ui_unittests.gypi
  Hunk #1 FAILED at 80.
  1 out of 1 hunk FAILED -- saving rejects to file ui/ui_unittests.gypi.rej

Patch:       ui/ui_unittests.gypi
Index: ui/ui_unittests.gypi
diff --git a/ui/ui_unittests.gypi b/ui/ui_unittests.gypi
index
b29649a63cfed766ba0010b1e13738c04034c571..dff773bca56c262f9e8bcc20b3968eeaf28d32b1
100644
--- a/ui/ui_unittests.gypi
+++ b/ui/ui_unittests.gypi
@@ -80,9 +80,11 @@
         'gfx/image/image_unittest_util_ios.mm',
         'gfx/image/image_unittest_util_mac.mm',
         'gfx/insets_unittest.cc',
+        'gfx/point_unittest.cc',
         'gfx/rect_unittest.cc',
         'gfx/screen_unittest.cc',
         'gfx/shadow_value_unittest.cc',
+        'gfx/size_unittest.cc',
         'gfx/skbitmap_operations_unittest.cc',
         'gfx/skia_util_unittest.cc',
       ],

[commit-bot: I haz the power, 2012-10-11 18:06:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11028127/11023

[commit-bot: I haz the power, 2012-10-11 18:31:23]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-11 18:48:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11028127/11025

[commit-bot: I haz the power, 2012-10-11 19:14:42]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-11 19:38:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11028127/11025

[commit-bot: I haz the power, 2012-10-11 21:52:25]

Change committed as 161415