webkit/plugins/ppapi/ppb_graphics_2d_impl_unittest.cc - Issue 11028127: Implicit coversion operators from integer geometry types to floating point.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppb_graphics_2d_impl_unittest.cc

Issue 11028127: Implicit coversion operators from integer geometry types to floating point. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: rebase Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/plugins/ppapi/ppb_graphics_2d_impl_unittest.cc

diff --git a/webkit/plugins/ppapi/ppb_graphics_2d_impl_unittest.cc b/webkit/plugins/ppapi/ppb_graphics_2d_impl_unittest.cc

index 85d756d220b86f6de0724cc2aa6465e5f406996a..e92720de97c01906f8b1b45abe5ecb976b66ec3c 100644

--- a/webkit/plugins/ppapi/ppb_graphics_2d_impl_unittest.cc

+++ b/webkit/plugins/ppapi/ppb_graphics_2d_impl_unittest.cc

@@ -66,7 +66,7 @@ TEST(PpapiGraphics2DImplTest, ConvertToLogicalPixels) {

gfx::Point delta(tests[i].dx1, tests[i].dy1);

bool res = webkit::ppapi::PPB_Graphics2D_Impl::ConvertToLogicalPixels(

tests[i].scale, &r1, &delta);

- EXPECT_TRUE(r1.Equals(r2));

+ EXPECT_EQ(r2.ToString(), r1.ToString());

EXPECT_EQ(res, tests[i].result);

if (res) {

EXPECT_EQ(delta, gfx::Point(tests[i].dx2, tests[i].dy2));

« no previous file with comments | « ui/ui_unittests.gypi ('k') | webkit/plugins/webview_plugin.cc » ('j') | no next file with comments »