MediaFileSystemRegistry unit tests.

MediaFileSystemRegistry unit tests.

TBR=asargent@chromium.org
BUG=NONE

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168172

[Lei Zhang, 2012-11-09 09:14:53]

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/ext...
File chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
(right):

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/ext...
chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc:6:
#include "base/file_path.h"
remove unused includes.

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
File chrome/browser/media_gallery/media_file_system_registry.cc (right):

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry.cc:136:
DCHECK(delegate_);
No need to check for OOM conditions

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
File chrome/browser/media_gallery/media_file_system_registry.h (right):

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry.h:147: size_t
GetExtensionHostCountForTests();
const

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
File chrome/browser/media_gallery/media_file_system_registry_unittest.cc
(right):

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:42: FSInfo()
{};
nit: no ;

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:72: int
fsid_;
Looks a bit weird when fsid_ is an int but fsid is a string on the next line.
Add a comment?

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:110:
DCHECK(entry);
No need for this. If we crash on the next line, it's pretty obvious what's
wrong.

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:124:
CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
we usually dcheck these.

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:163: mutable
ProfileRPHMap rph_map_;
why mutable?

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:173:
MediaGalleriesPreferences* GetPrefs();
GetMediaGalleryPrefs? I usually think GetPrefs would return a PrefService or
something.

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:192:
std::string name,
const ref both parameters?

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:256:
FilePath empty_dir_;
Can you mention these are inside |galleries_dir_| ?

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:268:
ScopedVector<ProfileState> profile_state_;
nit: profile_states_

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:313: for
(ProfileRPHMap::const_iterator it = rph_map_.begin();
This entire dtor is just a call to STLDeleteValues().

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:383:
scoped_refptr<extensions::Extension> ProfileState::AddApp(
Don't we have something similar to this in
chrome/browser/media_gallery/media_galleries_preferences_unittest.cc ? Can we
combine them into media_galleries_test_util.cc?

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:443:
browser_context_.reset(profile);
Do you have to do this? Can you use WebContentsTester::CreateTestWebContents()
instead?

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:461: //
Create a user added gallery based on the information passed and add it to
no need for a second copy of comments.

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:485:
location.value());
indentation

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:511:
ASSERT_LT(0U, galleries.size());
Unlike _EQ, there's not "expected" value here. So write this as ASSERT_GT(size,
0);

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
File chrome/browser/media_gallery/media_galleries_test_util.cc (right):

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_galleries_test_util.cc:7: #include
"chrome/common/chrome_paths.h"
alphabetical order

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/media_galleries_test_util.cc:40:
fake_dir_.path().Append(FILE_PATH_LITERAL(kDirectoryNames[i])),
Just AppendASCII() ?

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
File chrome/browser/media_gallery/mtp_device_delegate_impl.h (left):

https://chromiumcodereview.appspot.com/11027051/diff/15001/chrome/browser/med...
chrome/browser/media_gallery/mtp_device_delegate_impl.h:11: #if
!defined(SUPPORT_MTP_DEVICE_FILESYSTEM)
Why don't we leave this alone and put the #include in
media_file_system_registry.h behind defined(SUPPORT_MTP_DEVICE_FILESYSTEM) ?

[vandebo (ex-Chrome), 2012-11-13 06:50:18]

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/extensions/...
File chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
(right):

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/extensions/...
chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc:6:
#include "base/file_path.h"
On 2012/11/09 09:14:53, Lei Zhang wrote:
> remove unused includes.

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_file_system_registry.cc (right):

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry.cc:136:
DCHECK(delegate_);
On 2012/11/09 09:14:53, Lei Zhang wrote:
> No need to check for OOM conditions

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_file_system_registry.h (right):

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry.h:147: size_t
GetExtensionHostCountForTests();
On 2012/11/09 09:14:53, Lei Zhang wrote:
> const

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_file_system_registry_unittest.cc
(right):

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:42: FSInfo()
{};
On 2012/11/09 09:14:53, Lei Zhang wrote:
> nit: no ;

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:72: int
fsid_;
On 2012/11/09 09:14:53, Lei Zhang wrote:
> Looks a bit weird when fsid_ is an int but fsid is a string on the next line.
> Add a comment?

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:110:
DCHECK(entry);
On 2012/11/09 09:14:53, Lei Zhang wrote:
> No need for this. If we crash on the next line, it's pretty obvious what's
> wrong.

The segfault might end up being somewhat mysterious, the DCHECK is explicit and
would be easier to understand.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:124:
CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
On 2012/11/09 09:14:53, Lei Zhang wrote:
> we usually dcheck these.

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:163: mutable
ProfileRPHMap rph_map_;
On 2012/11/09 09:14:53, Lei Zhang wrote:
> why mutable?

Because RenderProcessHostFactory::CreateRenderProcessHost is const.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:173:
MediaGalleriesPreferences* GetPrefs();
On 2012/11/09 09:14:53, Lei Zhang wrote:
> GetMediaGalleryPrefs? I usually think GetPrefs would return a PrefService or
> something.

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:192:
std::string name,
On 2012/11/09 09:14:53, Lei Zhang wrote:
> const ref both parameters?

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:256:
FilePath empty_dir_;
On 2012/11/09 09:14:53, Lei Zhang wrote:
> Can you mention these are inside |galleries_dir_| ?

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:268:
ScopedVector<ProfileState> profile_state_;
On 2012/11/09 09:14:53, Lei Zhang wrote:
> nit: profile_states_

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:313: for
(ProfileRPHMap::const_iterator it = rph_map_.begin();
On 2012/11/09 09:14:53, Lei Zhang wrote:
> This entire dtor is just a call to STLDeleteValues().

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:383:
scoped_refptr<extensions::Extension> ProfileState::AddApp(
On 2012/11/09 09:14:53, Lei Zhang wrote:
> Don't we have something similar to this in
> chrome/browser/media_gallery/media_galleries_preferences_unittest.cc ? Can we
> combine them into media_galleries_test_util.cc?

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:443:
browser_context_.reset(profile);
On 2012/11/09 09:14:53, Lei Zhang wrote:
> Do you have to do this? Can you use WebContentsTester::CreateTestWebContents()
> instead?

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:461: //
Create a user added gallery based on the information passed and add it to
On 2012/11/09 09:14:53, Lei Zhang wrote:
> no need for a second copy of comments.

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:485:
location.value());
On 2012/11/09 09:14:53, Lei Zhang wrote:
> indentation

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:511:
ASSERT_LT(0U, galleries.size());
On 2012/11/09 09:14:53, Lei Zhang wrote:
> Unlike _EQ, there's not "expected" value here. So write this as
ASSERT_GT(size,
> 0);

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_galleries_test_util.cc (right):

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_galleries_test_util.cc:7: #include
"chrome/common/chrome_paths.h"
On 2012/11/09 09:14:53, Lei Zhang wrote:
> alphabetical order

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_galleries_test_util.cc:40:
fake_dir_.path().Append(FILE_PATH_LITERAL(kDirectoryNames[i])),
On 2012/11/09 09:14:53, Lei Zhang wrote:
> Just AppendASCII() ?

Done.

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
File chrome/browser/media_gallery/mtp_device_delegate_impl.h (left):

http://codereview.chromium.org/11027051/diff/15001/chrome/browser/media_galle...
chrome/browser/media_gallery/mtp_device_delegate_impl.h:11: #if
!defined(SUPPORT_MTP_DEVICE_FILESYSTEM)
On 2012/11/09 09:14:53, Lei Zhang wrote:
> Why don't we leave this alone and put the #include in
> media_file_system_registry.h behind defined(SUPPORT_MTP_DEVICE_FILESYSTEM) ?

Done.

[vandebo (ex-Chrome), 2012-11-15 00:38:53]

bots seem happy now.

[Lei Zhang, 2012-11-15 05:40:10]

+kmadhusu FYI since this will introduce a conflict.

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_file_system_registry.h (right):

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry.h:60: #if
defined(SUPPORT_MTP_DEVICE_FILESYSTEM)
This is going to conflict with https://codereview.chromium.org/11358243/

Who wants to go first?

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_file_system_registry_unittest.cc
(right):

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:141: class
MediaStorageUtilTest : public MediaStorageUtil {
This sounds like a test class. How about MediaStorageUtilForTesting or
MediaStorageTestUtil?

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:394:
content::BrowserContext* profile = state->profile.get();
Can the code from here to the end of the block go in ProfileState's ctor? Then
ProfileState can make more variables private and be more like a normal class.

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:502:
EXPECT_EQ(expected.size(), actual.size()) << test;
This needs to be ASSERT_EQ, or the for loop below need to run until
std::min(expected.size(), actual.size())

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:571:
ASSERT_TRUE(file_util::CreateDirectory(dcim_dir_.AppendASCII("DCIM")));
I added a constant for DCIM BTW.

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_galleries_test_util.cc (right):

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_galleries_test_util.cc:17: #include
"testing/gtest/include/gtest/gtest.h"
nit: not needed?

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_galleries_test_util.cc:24: Profile * profile)
{
nit: spacing

[vandebo (ex-Chrome), 2012-11-15 07:02:03]

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_file_system_registry_unittest.cc
(right):

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:141: class
MediaStorageUtilTest : public MediaStorageUtil {
On 2012/11/15 05:40:10, Lei Zhang wrote:
> This sounds like a test class. How about MediaStorageUtilForTesting or
> MediaStorageTestUtil?

Changed to TestMediaStorageUtil.

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:394:
content::BrowserContext* profile = state->profile.get();
On 2012/11/15 05:40:10, Lei Zhang wrote:
> Can the code from here to the end of the block go in ProfileState's ctor? Then
> ProfileState can make more variables private and be more like a normal class.

Done.

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:502:
EXPECT_EQ(expected.size(), actual.size()) << test;
On 2012/11/15 05:40:10, Lei Zhang wrote:
> This needs to be ASSERT_EQ, or the for loop below need to run until
> std::min(expected.size(), actual.size())

Done.

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:571:
ASSERT_TRUE(file_util::CreateDirectory(dcim_dir_.AppendASCII("DCIM")));
On 2012/11/15 05:40:10, Lei Zhang wrote:
> I added a constant for DCIM BTW.

Done.

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_galleries_test_util.cc (right):

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_galleries_test_util.cc:17: #include
"testing/gtest/include/gtest/gtest.h"
On 2012/11/15 05:40:10, Lei Zhang wrote:
> nit: not needed?

Needed for EXPECT_TRUE, ASSERT_TRUE, ASSERT_GT

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_galleries_test_util.cc:24: Profile * profile)
{
On 2012/11/15 05:40:10, Lei Zhang wrote:
> nit: spacing

Done.

[kmadhusu, 2012-11-15 17:31:09]

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_file_system_registry.h (right):

http://codereview.chromium.org/11027051/diff/12010/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry.h:60: #if
defined(SUPPORT_MTP_DEVICE_FILESYSTEM)
On 2012/11/15 05:40:10, Lei Zhang wrote:
> This is going to conflict with https://codereview.chromium.org/11358243/
> 
> Who wants to go first?

Looks like this CL is close to commit stage. So, you can commit first. I will
take care of the conflict.

[Lei Zhang, 2012-11-15 18:02:32]

lgtm

http://codereview.chromium.org/11027051/diff/22001/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_file_system_registry_unittest.cc
(right):

http://codereview.chromium.org/11027051/diff/22001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:187:
scoped_ptr<TestingProfile> profile;
I think |profile| can be private now.

http://codereview.chromium.org/11027051/diff/22001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:189:
scoped_refptr<extensions::Extension> all_permission_extension;
And these can be private with a simple accessor.

[vandebo (ex-Chrome), 2012-11-16 06:04:32]

Change in chrome/browser/extension is a simple refactor, TBRing asargent...

http://codereview.chromium.org/11027051/diff/22001/chrome/browser/media_galle...
File chrome/browser/media_gallery/media_file_system_registry_unittest.cc
(right):

http://codereview.chromium.org/11027051/diff/22001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:187:
scoped_ptr<TestingProfile> profile;
On 2012/11/15 18:02:32, Lei Zhang wrote:
> I think |profile| can be private now.

Done.

http://codereview.chromium.org/11027051/diff/22001/chrome/browser/media_galle...
chrome/browser/media_gallery/media_file_system_registry_unittest.cc:189:
scoped_refptr<extensions::Extension> all_permission_extension;
On 2012/11/15 18:02:32, Lei Zhang wrote:
> And these can be private with a simple accessor.

Done.

[commit-bot: I haz the power, 2012-11-16 06:04:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/11027051/29002

[commit-bot: I haz the power, 2012-11-16 06:05:02]

Failed to apply patch for chrome/chrome_tests_unit.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/chrome_tests_unit.gypi
  Hunk #1 FAILED at 122.
  Hunk #2 succeeded at 833 (offset 25 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/chrome_tests_unit.gypi.rej

Patch:       chrome/chrome_tests_unit.gypi
Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index
27602b1997f3ac1ffd80be45f4044375882edf47..03535ca484040b1a7aaf7a1691ca284ebd94bad3
100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -122,6 +122,8 @@
         'browser/browsing_data/mock_browsing_data_quota_helper.h',
         'browser/browsing_data/mock_browsing_data_server_bound_cert_helper.cc',
         'browser/browsing_data/mock_browsing_data_server_bound_cert_helper.h',
+        'browser/media_gallery/media_galleries_test_util.cc',
+        'browser/media_gallery/media_galleries_test_util.h',
         'browser/net/url_request_mock_link_doctor_job.cc',
         'browser/net/url_request_mock_link_doctor_job.h',
         'browser/net/url_request_mock_util.cc',
@@ -808,6 +810,7 @@
         'browser/managed_mode/managed_mode_unittest.cc',
         'browser/managed_mode/managed_mode_url_filter_unittest.cc',
         'browser/media/media_internals_unittest.cc',
+        'browser/media_gallery/media_file_system_registry_unittest.cc',
         'browser/media_gallery/media_galleries_dialog_controller_mock.cc',
         'browser/media_gallery/media_galleries_dialog_controller_mock.h',
         'browser/media_gallery/media_galleries_preferences_unittest.cc',

[commit-bot: I haz the power, 2012-11-16 06:16:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/11027051/32001

[commit-bot: I haz the power, 2012-11-16 10:00:19]

Change committed as 168172

[asargent_no_longer_on_chrome, 2012-11-16 19:29:22]

lgtm ex post facto