Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: base/metrics/sample_vector.h

Issue 11022002: Add SampleMap and use it in SparseHistogram (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address more comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/sample_map_unittest.cc ('k') | base/metrics/sample_vector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/sample_vector.h
diff --git a/base/metrics/sample_vector.h b/base/metrics/sample_vector.h
index 8938d362a754b99626b7110d7b6dcc540f3913bb..67c344a97c31ff550a5f25a6e45c86f961b82bc5 100644
--- a/base/metrics/sample_vector.h
+++ b/base/metrics/sample_vector.h
@@ -39,7 +39,7 @@ class BASE_EXPORT_PRIVATE SampleVector : public HistogramSamples {
protected:
virtual bool AddSubtractImpl(
SampleCountIterator* iter,
- HistogramSamples::Instruction instruction) OVERRIDE;
+ HistogramSamples::Operator op) OVERRIDE; // |op| is ADD or SUBTRACT.
virtual size_t GetBucketIndex(HistogramBase::Sample value) const;
@@ -58,6 +58,7 @@ class BASE_EXPORT_PRIVATE SampleVectorIterator : public SampleCountIterator {
public:
SampleVectorIterator(const std::vector<HistogramBase::Count>* counts,
const BucketRanges* bucket_ranges);
+ virtual ~SampleVectorIterator();
// SampleCountIterator implementation:
virtual bool Done() const OVERRIDE;
@@ -65,6 +66,8 @@ class BASE_EXPORT_PRIVATE SampleVectorIterator : public SampleCountIterator {
virtual void Get(HistogramBase::Sample* min,
HistogramBase::Sample* max,
HistogramBase::Count* count) const OVERRIDE;
+
+ // SampleVector uses predefined buckets, so iterator can return bucket index.
virtual bool GetBucketIndex(size_t* index) const OVERRIDE;
private:
« no previous file with comments | « base/metrics/sample_map_unittest.cc ('k') | base/metrics/sample_vector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698