Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2955)

Unified Diff: base/metrics/sample_vector.cc

Issue 11022002: Add SampleMap and use it in SparseHistogram (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address more comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/sample_vector.h ('k') | base/metrics/sample_vector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/sample_vector.cc
diff --git a/base/metrics/sample_vector.cc b/base/metrics/sample_vector.cc
index 327a1f2900dbb858f17751a4f9f0d7411bf8d4b3..f90d80bd38759a803656413e3d3d145e4443a5b0 100644
--- a/base/metrics/sample_vector.cc
+++ b/base/metrics/sample_vector.cc
@@ -53,7 +53,7 @@ scoped_ptr<SampleCountIterator> SampleVector::Iterator() const {
}
bool SampleVector::AddSubtractImpl(SampleCountIterator* iter,
- HistogramSamples::Instruction instruction) {
+ HistogramSamples::Operator op) {
HistogramBase::Sample min;
HistogramBase::Sample max;
HistogramBase::Count count;
@@ -65,8 +65,7 @@ bool SampleVector::AddSubtractImpl(SampleCountIterator* iter,
if (min == bucket_ranges_->range(index) &&
max == bucket_ranges_->range(index + 1)) {
// Sample matches this bucket!
- counts_[index] +=
- (instruction == HistogramSamples::ADD) ? count : -count;
+ counts_[index] += (op == HistogramSamples::ADD) ? count : -count;
iter->Next();
} else if (min > bucket_ranges_->range(index)) {
// Sample is larger than current bucket range. Try next.
@@ -117,6 +116,8 @@ SampleVectorIterator::SampleVectorIterator(const vector<Count>* counts,
SkipEmptyBuckets();
}
+SampleVectorIterator::~SampleVectorIterator() {}
+
bool SampleVectorIterator::Done() const {
return index_ >= counts_->size();
}
« no previous file with comments | « base/metrics/sample_vector.h ('k') | base/metrics/sample_vector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698