Remove Shell::shelf()|status_area_widget()|launcher()

Remove Shell::shelf|status_area_widget|launcher and
updated all clients to use one on RootWindowController and/or
Launcher::ForPrimaryDisplay/ForWindow.

BUG=145978
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162664

[oshima, 2012-10-17 15:26:41]

it touches a lot of codes, but most of them are simple conversions.

http://codereview.chromium.org/11017079/diff/18078/ash/screen_ash.cc
File ash/screen_ash.cc (right):

http://codereview.chromium.org/11017079/diff/18078/ash/screen_ash.cc#newcode54
ash/screen_ash.cc:54: }
These two methods will be gone after
http://codereview.chromium.org/10979090.

[sky, 2012-10-17 16:25:20]

http://codereview.chromium.org/11017079/diff/14026/ash/launcher/launcher.h
File ash/launcher/launcher.h (right):

http://codereview.chromium.org/11017079/diff/14026/ash/launcher/launcher.h#ne...
ash/launcher/launcher.h:47: // Return the launcher for the primary display.
Document these may be NULL when not logged in.

http://codereview.chromium.org/11017079/diff/14026/ash/shell.h
File ash/shell.h (right):

http://codereview.chromium.org/11017079/diff/14026/ash/shell.h#newcode344
ash/shell.h:344: WebNotificationTray* GetWebNotificationTray();
I thought we were only going to have the tray on the primary monitor? Maybe I'm
wrong there.

http://codereview.chromium.org/11017079/diff/14026/ash/wm/shelf_layout_manage...
File ash/wm/shelf_layout_manager.cc (right):

http://codereview.chromium.org/11017079/diff/14026/ash/wm/shelf_layout_manage...
ash/wm/shelf_layout_manager.cc:234: StatusAreaWidget* status_area_widget =
Change this class to take the statusareawidget as StatusAreaWidget instead of as
a views::Widget. That way we can get rid of all the lookup and use status_.

http://codereview.chromium.org/11017079/diff/14026/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

http://codereview.chromium.org/11017079/diff/14026/ash/wm/window_animations.c...
ash/wm/window_animations.cc:400: gfx::Rect target_bounds =
Launcher::ForWindow(window)->
This should NULL check launcher.

http://codereview.chromium.org/11017079/diff/14026/ash/wm/workspace/frame_max...
File ash/wm/workspace/frame_maximize_button.cc (right):

http://codereview.chromium.org/11017079/diff/14026/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:480: Launcher* launcher =
Launcher::ForWindow(window);
null check launcher.

http://codereview.chromium.org/11017079/diff/14026/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_manager_unittest.cc (right):

http://codereview.chromium.org/11017079/diff/14026/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_manager_unittest.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
This file has been nuked.

[oshima, 2012-10-17 17:49:43]

http://codereview.chromium.org/11017079/diff/14026/ash/launcher/launcher.h
File ash/launcher/launcher.h (right):

http://codereview.chromium.org/11017079/diff/14026/ash/launcher/launcher.h#ne...
ash/launcher/launcher.h:47: // Return the launcher for the primary display.
On 2012/10/17 16:25:20, sky wrote:
> Document these may be NULL when not logged in.

Done.

http://codereview.chromium.org/11017079/diff/14026/ash/shell.h
File ash/shell.h (right):

http://codereview.chromium.org/11017079/diff/14026/ash/shell.h#newcode344
ash/shell.h:344: WebNotificationTray* GetWebNotificationTray();
On 2012/10/17 16:25:20, sky wrote:
> I thought we were only going to have the tray on the primary monitor? Maybe
I'm
> wrong there.

All launchers will have trays (menu/battery/ime), except for notifications
Notifications are shown only on primary for now.

http://codereview.chromium.org/11017079/diff/14026/ash/wm/shelf_layout_manage...
File ash/wm/shelf_layout_manager.cc (right):

http://codereview.chromium.org/11017079/diff/14026/ash/wm/shelf_layout_manage...
ash/wm/shelf_layout_manager.cc:234: StatusAreaWidget* status_area_widget =
On 2012/10/17 16:25:20, sky wrote:
> Change this class to take the statusareawidget as StatusAreaWidget instead of
as
> a views::Widget. That way we can get rid of all the lookup and use status_.

Done.

http://codereview.chromium.org/11017079/diff/14026/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

http://codereview.chromium.org/11017079/diff/14026/ash/wm/window_animations.c...
ash/wm/window_animations.cc:400: gfx::Rect target_bounds =
Launcher::ForWindow(window)->
On 2012/10/17 16:25:20, sky wrote:
> This should NULL check launcher.

There wasn't null check. Why we need now?

http://codereview.chromium.org/11017079/diff/14026/ash/wm/workspace/frame_max...
File ash/wm/workspace/frame_maximize_button.cc (right):

http://codereview.chromium.org/11017079/diff/14026/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:480: Launcher* launcher =
Launcher::ForWindow(window);
On 2012/10/17 16:25:20, sky wrote:
> null check launcher.

same q

http://codereview.chromium.org/11017079/diff/14026/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_manager_unittest.cc (right):

http://codereview.chromium.org/11017079/diff/14026/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_manager_unittest.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2012/10/17 16:25:20, sky wrote:
> This file has been nuked.
rebased

[sky, 2012-10-17 21:22:56]

http://codereview.chromium.org/11017079/diff/14026/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

http://codereview.chromium.org/11017079/diff/14026/ash/wm/window_animations.c...
ash/wm/window_animations.cc:400: gfx::Rect target_bounds =
Launcher::ForWindow(window)->
On 2012/10/17 17:49:43, oshima wrote:
> On 2012/10/17 16:25:20, sky wrote:
> > This should NULL check launcher.
> 
> There wasn't null check. Why we need now?

It's a bug. The launcher is lazily created.

[oshima, 2012-10-17 22:27:48]

On 2012/10/17 21:22:56, sky wrote:
> http://codereview.chromium.org/11017079/diff/14026/ash/wm/window_animations.cc
> File ash/wm/window_animations.cc (right):
> 
>
http://codereview.chromium.org/11017079/diff/14026/ash/wm/window_animations.c...
> ash/wm/window_animations.cc:400: gfx::Rect target_bounds =
> Launcher::ForWindow(window)->
> On 2012/10/17 17:49:43, oshima wrote:
> > On 2012/10/17 16:25:20, sky wrote:
> > > This should NULL check launcher.
> > 
> > There wasn't null check. Why we need now?
> 
> It's a bug. The launcher is lazily created.

ok, done

[sky, 2012-10-18 00:00:42]

LGTM

[commit-bot: I haz the power, 2012-10-18 04:32:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/11017079/22134

[commit-bot: I haz the power, 2012-10-18 07:11:06]

Change committed as 162664