Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: chrome/browser/ui/ash/shelf_browsertest.cc

Issue 11017079: Remove Shell::shelf()|status_area_widget()|launcher() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/root_window_controller.h"
5 #include "ash/shell.h" 6 #include "ash/shell.h"
6 #include "ash/wm/shelf_layout_manager.h" 7 #include "ash/wm/shelf_layout_manager.h"
7 #include "ash/wm/workspace_controller.h" 8 #include "ash/wm/workspace_controller.h"
8 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
9 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/browser_window.h" 11 #include "chrome/browser/ui/browser_window.h"
11 #include "chrome/browser/ui/status_bubble.h" 12 #include "chrome/browser/ui/status_bubble.h"
12 #include "chrome/test/base/in_process_browser_test.h" 13 #include "chrome/test/base/in_process_browser_test.h"
13 14
14 typedef InProcessBrowserTest ShelfBrowserTest; 15 typedef InProcessBrowserTest ShelfBrowserTest;
15 16
16 // Confirm that a status bubble doesn't cause the shelf to darken. 17 // Confirm that a status bubble doesn't cause the shelf to darken.
17 IN_PROC_BROWSER_TEST_F(ShelfBrowserTest, StatusBubble) { 18 IN_PROC_BROWSER_TEST_F(ShelfBrowserTest, StatusBubble) {
18 ash::Shell* shell = ash::Shell::GetInstance(); 19 ash::internal::ShelfLayoutManager* shelf =
19 ash::internal::ShelfLayoutManager* shelf = shell->shelf(); 20 ash::internal::RootWindowController::ForLauncher(
21 browser()->window()->GetNativeWindow())->shelf();
20 EXPECT_TRUE(shelf->IsVisible()); 22 EXPECT_TRUE(shelf->IsVisible());
21 23
22 // Ensure that the browser abuts the shelf. 24 // Ensure that the browser abuts the shelf.
23 const gfx::Rect old_bounds = browser()->window()->GetBounds(); 25 const gfx::Rect old_bounds = browser()->window()->GetBounds();
24 const gfx::Rect new_bounds( 26 const gfx::Rect new_bounds(
25 old_bounds.x(), 27 old_bounds.x(),
26 old_bounds.y(), 28 old_bounds.y(),
27 old_bounds.width(), 29 old_bounds.width(),
28 shelf->GetIdealBounds().y() - old_bounds.y()); 30 shelf->GetIdealBounds().y() - old_bounds.y());
29 browser()->window()->SetBounds(new_bounds); 31 browser()->window()->SetBounds(new_bounds);
30 EXPECT_FALSE(shelf->window_overlaps_shelf()); 32 EXPECT_FALSE(shelf->window_overlaps_shelf());
31 33
32 // Show status, which will overlap the shelf by a pixel. 34 // Show status, which will overlap the shelf by a pixel.
33 browser()->window()->GetStatusBubble()->SetStatus( 35 browser()->window()->GetStatusBubble()->SetStatus(
34 UTF8ToUTF16("Dummy Status Text")); 36 UTF8ToUTF16("Dummy Status Text"));
35 shelf->UpdateVisibilityState(); 37 shelf->UpdateVisibilityState();
36 38
37 // Ensure that status doesn't cause overlap. 39 // Ensure that status doesn't cause overlap.
38 EXPECT_FALSE(shelf->window_overlaps_shelf()); 40 EXPECT_FALSE(shelf->window_overlaps_shelf());
39 } 41 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698