Issue 11016032: Add protected against empty binary file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11016032: Add protected against empty binary file. (Closed)

Created:
8 years, 2 months ago by M-A Ruel

Modified:
8 years, 2 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Add protected against empty binary file and disable all binary file support. If a file is empty, it's not a binary file in the first place. This is to protect against improper uploads. From light testing, it seems binary file support is totally broken. This needs to be verified throughout before being enabled back. TBR=rogerta@chromium.org BUG=23608 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159941

Patch Set 1 #

Patch Set 2 : Disallow all binary files #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	rietveld.py	View	1	1 chunk	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/11016032/2001

8 years, 2 months ago (2012-10-03 19:08:08 UTC) #2

Change committed as 159941

Expand Messages | Collapse Messages