Add protected against empty binary file.

rietveld.py

 # coding: utf-8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Defines class Rietveld to easily access a rietveld instance.
 
 Security implications:
 
 The following hypothesis are made:
 - Rietveld enforces:
@@ skipping 118 matching lines @@
       svn_props = self.parse_svn_properties(
           state.get('property_changes', ''), filename)
 
       if state.get('is_binary'):
         if status[0] == 'D':
           if status[0] != status.strip():
             raise patch.UnsupportedPatchFormat(
                 filename, 'Deleted file shouldn\'t have property change.')
           out.append(patch.FilePatchDelete(filename, state['is_binary']))
         else:
-          out.append(patch.FilePatchBinary(
+          content = self.get_file_content(issue, patchset, state['id'])
+          if not content:
+            # As a precaution due to a bug in upload.py for git checkout, refuse
+            # empty files. If it's empty, it's not a binary file.
+            raise patch.UnsupportedPatchFormat(
+                filename,
+                'Binary file is empty. Maybe the file wasn\'t uploaded in the '
+                'first place?')
+          raise patch.UnsupportedPatchFormat(
               filename,
-              self.get_file_content(issue, patchset, state['id']),
-              svn_props,
-              is_new=(status[0] == 'A')))
+              'Binary file support is temporarilly disabled due to a bug. '
+              'Please commit blindly the binary files first then commit the '
+              'source change as a separate CL. Sorry for the annoyance.')
+          #out.append(patch.FilePatchBinary(
+          #    filename,
+          #    content,
+          #    svn_props,
+          #    is_new=(status[0] == 'A')))
         continue
 
       try:
         diff = self.get_file_diff(issue, patchset, state['id'])
       except urllib2.HTTPError, e:
         if e.code == 404:
           raise patch.UnsupportedPatchFormat(
               filename, 'File doesn\'t have a diff.')
         raise
 
@@ skipping 220 matching lines @@
           if not 'Name or service not known' in e.reason:
             # Usually internal GAE flakiness.
             raise
         # If reaching this line, loop again. Uses a small backoff.
         time.sleep(1+maxtries*2)
     finally:
       upload.ErrorExit = old_error_exit
 
   # DEPRECATED.
   Send = get