Ignore device status check emailing exceptions.

Ignore device status check emailing exceptions.

The Android device status checker will attempt to alert by email when
a device fails. If the email step generates an exception, we don't
want to fail the 'Device Status Check' build step, because that causes
the entire build to fail.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159936

[John Knottenbelt, 2012-10-03 14:51:00]

Hi guys, 

This try job failed because the SMTP step in the device checker exceptioned:

http://build.chromium.org/p/tryserver.chromium/builders/android_fyi_dbg_trigg...

It seems bad that the whole try job is failed because of this. How does the
above fix look?

Thanks

John

[bulach, 2012-10-03 15:02:24]

lgtm, sounds reasonable to me..

just a nit:

https://codereview.chromium.org/11013024/diff/1/build/android/device_status_c...
File build/android/device_status_check.py (right):

https://codereview.chromium.org/11013024/diff/1/build/android/device_status_c...
build/android/device_status_check.py:123: except Exception, exception:
nit: s/,/as/
except Exception as e:

[navabi1, 2012-10-03 15:55:28]

lgtm

[navabi1, 2012-10-03 15:56:16]

Looks good to me. Thanks for this fix John.


On Wed, Oct 3, 2012 at 8:44 AM, <jknotten@chromium.org> wrote:

>
https://codereview.chromium.**org/11013024/<https://codereview.chromium.org/1...
>

[Isaac (away), 2012-10-03 16:11:02]

This is OK as a quick fix, but I would like this reverted once smtp server
issues are ironed out.

[commit-bot: I haz the power, 2012-10-03 16:22:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jknotten@chromium.org/11013024/2002

[navabi, 2012-10-03 16:32:49]

On 2012/10/03 16:22:44, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/jknotten%40chromium.org/11013024/2002

Will track progress of smtp server issues on the original bug:
https://code.google.com/p/chromium/issues/detail?id=152583

[commit-bot: I haz the power, 2012-10-03 18:52:43]

Change committed as 159936