Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: build/android/device_status_check.py

Issue 11013024: Ignore device status check emailing exceptions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use 'as' instead of ',' Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/device_status_check.py
diff --git a/build/android/device_status_check.py b/build/android/device_status_check.py
index 851fd94978bf80758a97aa83da1c05c6426200a8..50d8e8b24ba6aae01e912fcba49d4a4d01b77e29 100755
--- a/build/android/device_status_check.py
+++ b/build/android/device_status_check.py
@@ -116,9 +116,12 @@ def CheckForMissingDevices(options, adb_online_devs):
'To: %s' % to_address,
'Subject: %s' % subject,
'', body])
- server = smtplib.SMTP('localhost')
- server.sendmail(from_address, [to_address], msg_body)
- server.quit()
+ try:
+ server = smtplib.SMTP('localhost')
+ server.sendmail(from_address, [to_address], msg_body)
+ server.quit()
+ except Exception as e:
+ print 'Failed to send alert email. Error: %s' % e
else:
new_devs = set(adb_online_devs) - set(last_devices)
if new_devs and os.path.exists(last_devices_path):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698