Throw AbstractClassInstantiationError on abstract class instantiation.

Throw AbstractClassInstantiationError on abstract class instantiation.

BUG=dartbug.com/4737
TEST=

Kasper deployed this as  https://codereview.chromium.org//11109012

[aam-me, 2012-10-01 05:26:41]

Peter, please, take a look when you have a chance.
I am not sure what you had in mind regarding letting listener know about
"abstract" modifier.
I added boolean isAbstract flag instead of reusing Modifiers structure. I
thought that general Modifiers would be too heavy for just single 'abstract'
flag purposes.

Thanks!

[ahe, 2012-10-10 07:58:51]

Hi Alexander,

Johnni also made changes in this area, see:
https://codereview.chromium.org/10990108/

Could you rebase this CL on top of Johnni's changes?

[ahe, 2012-10-10 08:15:24]

Perhaps you should wait a little bit on this. I remember there was some
controversy surrounding this runtime error, so I'll create a test and ask Gilad,
Lars, and Kasper to all approve it.

[ahe, 2012-10-11 08:01:47]

On 2012/10/10 08:15:24, ahe wrote:
> Perhaps you should wait a little bit on this. I remember there was some
> controversy surrounding this runtime error, so I'll create a test and ask
Gilad,
> Lars, and Kasper to all approve it.

I have submitted CL 11017052, and it seems everyone agrees on the semantics you
have implemented. Let me know when you have rebased this on 10990108.

[aam-me, 2012-10-11 17:41:45]

Peter, I have merged my changes with Johnni's CL.

Please, take a look when you have a second.

Thanks!

[ahe, 2012-10-11 18:27:07]

LGTM!

https://chromiumcodereview.appspot.com/11013010/diff/9001/lib/compiler/implem...
File lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/11013010/diff/9001/lib/compiler/implem...
lib/compiler/implementation/elements/elements.dart:1320: int initialState)
If unchanged, please just keep the old formatting. Then "svn blame" works better
:-)

https://chromiumcodereview.appspot.com/11013010/diff/9001/lib/core/errors.dart
File lib/core/errors.dart (right):

https://chromiumcodereview.appspot.com/11013010/diff/9001/lib/core/errors.dar...
lib/core/errors.dart:52: final String _className;
Please use this order of members:

fields
constructors
methods

[aam-me, 2012-10-12 01:14:05]

Thank you for the feedback, Peter.

Please take another look.

https://chromiumcodereview.appspot.com/11013010/diff/9001/lib/compiler/implem...
File lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/11013010/diff/9001/lib/compiler/implem...
lib/compiler/implementation/elements/elements.dart:1320: int initialState)
On 2012/10/11 18:27:07, ahe wrote:
> If unchanged, please just keep the old formatting. Then "svn blame" works
better
> :-)

Done.

https://chromiumcodereview.appspot.com/11013010/diff/9001/lib/core/errors.dart
File lib/core/errors.dart (right):

https://chromiumcodereview.appspot.com/11013010/diff/9001/lib/core/errors.dar...
lib/core/errors.dart:52: final String _className;
On 2012/10/11 18:27:07, ahe wrote:
> Please use this order of members:
> 
> fields
> constructors
> methods

Done.

[kasperl, 2012-10-12 11:01:21]

I'm trying to land this as is here: https://codereview.chromium.org/11109012/.

Cheers,
Kasper

[ahe, 2012-10-12 11:06:49]

LGTM!