Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: src/trusted/validator_ragel/unreviewed/validator.h

Issue 11000033: Move validator_x86_XX.rl out of unreviewed. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_ragel/unreviewed/validator.h
===================================================================
--- src/trusted/validator_ragel/unreviewed/validator.h (revision 9996)
+++ src/trusted/validator_ragel/unreviewed/validator.h (working copy)
@@ -7,11 +7,15 @@
#ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_VALIDATOR_H_
#define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_VALIDATOR_H_
-#include "native_client/src/trusted/validator_ragel/unreviewed/decoder.h"
+#include "native_client/src/trusted/validator_ragel/decoder.h"
EXTERN_C_BEGIN
-enum validation_callback_info {
+/*
+ * Bits and masks used to transfer information from validator to user_callback.
+ * See validator_internals.html for details.
+ */
+enum ValidationCallbackInfo {
/* Anyfield info mask: you can use to parse information about anyfields. */
ANYFIELD_INFO_MASK = 0x000000ff,
/* Immediate sizes (immediates always come at the end of instruction). */
@@ -99,7 +103,8 @@
* When callback is called for invalid jump tagret,
* instruction_start = instruction_end = jump target
*
- * Minimal user_callback looks like this:
+ * Minimal user_callback for CALL_USER_CALLBACK_ON_EACH_INSTRUCTION case looks
+ * like this:
* ...
* if (validation_info & (VALIDATION_ERRORS_MASK | BAD_JUMP_TARGET))
* return FALSE;

Powered by Google App Engine
This is Rietveld 408576698