Move validator_x86_XX.rl out of unreviewed.

src/trusted/validator_ragel/unreviewed/validator.h

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_VALIDATOR_H_
 #define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_VALIDATOR_H_
 
-#include "native_client/src/trusted/validator_ragel/unreviewed/decoder.h"
+#include "native_client/src/trusted/validator_ragel/decoder.h"
 
 EXTERN_C_BEGIN
 
-enum validation_callback_info {
+/*
+ * Bits and masks used to transfer information from validator to user_callback.
+ * See validator_internals.html for details.
+ */
+enum ValidationCallbackInfo {
   /* Anyfield info mask: you can use to parse information about anyfields.  */
   ANYFIELD_INFO_MASK            = 0x000000ff,
   /* Immediate sizes (immediates always come at the end of instruction).  */
   IMMEDIATES_SIZE_MASK          = 0x0000000f,
   IMMEDIATE_8BIT                = 0x00000001,
   IMMEDIATE_16BIT               = 0x00000002,
   IMMEDIATE_32BIT               = 0x00000004,
   IMMEDIATE_64BIT               = 0x00000008,
   /* Second 8bit immediate is only used in "extrq/insertq" instructions.  */
   SECOND_IMMEDIATE_8BIT         = 0x00000011,
@@ skipping 67 matching lines @@
 /*
  * Callback is invoked by ValidateChunk* for all erroneous instructions
  * (or for all instructions if CALL_USER_CALLBACK_ON_EACH_INSTRUCTION is set).
  * It's up to the callback to decide whether this particual place is indeed
  * a violation. If callback returns FALSE at least once, validation result
  * becomes FALSE.
  *
  * When callback is called for invalid jump tagret,
  *   instruction_start = instruction_end = jump target
  *
- * Minimal user_callback looks like this:
+ * Minimal user_callback for CALL_USER_CALLBACK_ON_EACH_INSTRUCTION case looks
+ * like this:
  *   ...
  *   if (validation_info & (VALIDATION_ERRORS_MASK | BAD_JUMP_TARGET))
  *     return FALSE;
  *   else
  *     return TRUE;
  *   ...
  */
 typedef Bool (*ValidationCallbackFunc) (const uint8_t *instruction_start,
                                         const uint8_t *instruction_end,
                                         uint32_t validation_info,
@@ skipping 23 matching lines @@
  */
 Bool ValidateChunkIA32(const uint8_t *data, size_t size,
                        enum ValidationOptions options,
                        const NaClCPUFeaturesX86 *cpu_features,
                        ValidationCallbackFunc user_callback,
                        void *callback_data);
 
 EXTERN_C_END
 
 #endif  /* NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_VALIDATOR_H_ */