Sanity checks to make sure we are not trying to clear Content Licenses when Flash Pepper is not in …

Sanity checks to make sure we are not trying to clear Content Licenses when Flash Pepper is not in use.

Added sanity checks to ClearBrowserDataHandler to ensure that when it calls BrowsingDataRemover::Remove, the |remove_mask| will not have the REMOVE_CONTENT_LICENSES flag set when PPAPI Flash is disabled -- even if the corresponding "Deauthorize Content Licenses" checkbox on the "Clear Browsing Data" dialog is checked.

This is required because while removing Content Licenses is only possible with PPAPI Flash, the checked state for the check-box is persisted, and thus even though the check-box gets hidden when PPAPI Flash is disabled, it will still be checked behind the curtains, and would cause the above-mentioned flag to be set.

We opt to keep the persisted checked-state for the check-box though, to provide consistency in the case PPAPI Flash gets re-enabled later.

This is the first of two CLs to address the issue mentioned below. It is in itself enough to fix the issue, but given that the issue actually discovered two bugs, there is an other CL to fix the other bug too. See issue for details.

BUG=144874
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159667

[engedy, 2012-09-29 17:29:38]

Please review this one also.

[yzshen1, 2012-09-30 18:27:01]

LGTM

Thanks for fixing the bug!

[commit-bot: I haz the power, 2012-10-01 08:23:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/engedy@chromium.org/11000022/1

[commit-bot: I haz the power, 2012-10-01 08:23:13]

Presubmit check for 11000022-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/webui/options

[engedy, 2012-10-01 08:27:06]

Could you please review for owner's approval?

[Evan Stade, 2012-10-01 08:45:39]

lgtm

http://codereview.chromium.org/11000022/diff/1/chrome/browser/ui/webui/option...
File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right):

http://codereview.chromium.org/11000022/diff/1/chrome/browser/ui/webui/option...
chrome/browser/ui/webui/options/clear_browser_data_handler.cc:143:
*pepper_flash_settings_enabled_)
curlies

[engedy, 2012-10-01 08:53:00]

http://codereview.chromium.org/11000022/diff/1/chrome/browser/ui/webui/option...
File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right):

http://codereview.chromium.org/11000022/diff/1/chrome/browser/ui/webui/option...
chrome/browser/ui/webui/options/clear_browser_data_handler.cc:143:
*pepper_flash_settings_enabled_)
On 2012/10/01 08:45:39, Evan Stade wrote:
> curlies

Done.

[commit-bot: I haz the power, 2012-10-01 08:53:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/engedy@chromium.org/11000022/9002

[commit-bot: I haz the power, 2012-10-01 08:56:38]

Retried try job too often for step(s) compile

[engedy, 2012-10-01 09:08:53]

On 2012/10/01 08:56:38, I haz the power (commit-bot) wrote:
> Retried try job too often for step(s) compile

Trybots failed to apply patch, rebased changes.

[commit-bot: I haz the power, 2012-10-01 09:09:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/engedy@chromium.org/11000022/9004

[commit-bot: I haz the power, 2012-10-01 09:12:58]

Retried try job too often for step(s) compile

[commit-bot: I haz the power, 2012-10-01 17:37:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/engedy@chromium.org/11000022/9004

[commit-bot: I haz the power, 2012-10-01 17:42:40]

Retried try job too often for step(s) crypto_unittests, unit_tests,
cacheinvalidation_unittests, remoting_unittests, jingle_unittests,
nacl_integration, ipc_tests, interactive_ui_tests, browser_tests, net_unittests,
content_unittests, gpu_unittests, base_unittests, sync_integration_tests,
media_unittests, safe_browsing_tests, content_browsertests, sql_unittests,
printing_unittests, sync_unit_tests, check_deps

[commit-bot: I haz the power, 2012-10-02 08:18:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/engedy@chromium.org/11000022/9004

[commit-bot: I haz the power, 2012-10-02 10:34:52]

Change committed as 159667