Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

Issue 11000022: Sanity checks to make sure we are not trying to clear Content Licenses when Flash Pepper is not in … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/webui/options/clear_browser_data_handler.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/clear_browser_data_handler.h" 5 #include "chrome/browser/ui/webui/options/clear_browser_data_handler.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/string16.h" 10 #include "base/string16.h"
(...skipping 25 matching lines...) Expand all
36 36
37 ClearBrowserDataHandler::~ClearBrowserDataHandler() { 37 ClearBrowserDataHandler::~ClearBrowserDataHandler() {
38 if (remover_) 38 if (remover_)
39 remover_->RemoveObserver(this); 39 remover_->RemoveObserver(this);
40 } 40 }
41 41
42 void ClearBrowserDataHandler::InitializeHandler() { 42 void ClearBrowserDataHandler::InitializeHandler() {
43 clear_plugin_lso_data_enabled_.Init(prefs::kClearPluginLSODataEnabled, 43 clear_plugin_lso_data_enabled_.Init(prefs::kClearPluginLSODataEnabled,
44 Profile::FromWebUI(web_ui())->GetPrefs(), 44 Profile::FromWebUI(web_ui())->GetPrefs(),
45 NULL); 45 NULL);
46 pepper_flash_settings_enabled_.Init(prefs::kPepperFlashSettingsEnabled,
47 Profile::FromWebUI(web_ui())->GetPrefs(),
48 NULL);
46 } 49 }
47 50
48 void ClearBrowserDataHandler::GetLocalizedValues( 51 void ClearBrowserDataHandler::GetLocalizedValues(
49 DictionaryValue* localized_strings) { 52 DictionaryValue* localized_strings) {
50 DCHECK(localized_strings); 53 DCHECK(localized_strings);
51 54
52 static OptionsStringResource resources[] = { 55 static OptionsStringResource resources[] = {
53 { "clearBrowserDataLabel", IDS_CLEAR_BROWSING_DATA_LABEL }, 56 { "clearBrowserDataLabel", IDS_CLEAR_BROWSING_DATA_LABEL },
54 { "deleteBrowsingHistoryCheckbox", IDS_DEL_BROWSING_HISTORY_CHKBOX }, 57 { "deleteBrowsingHistoryCheckbox", IDS_DEL_BROWSING_HISTORY_CHKBOX },
55 { "deleteDownloadHistoryCheckbox", IDS_DEL_DOWNLOAD_HISTORY_CHKBOX }, 58 { "deleteDownloadHistoryCheckbox", IDS_DEL_DOWNLOAD_HISTORY_CHKBOX },
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 if (prefs->GetBoolean(prefs::kDeleteCache)) 131 if (prefs->GetBoolean(prefs::kDeleteCache))
129 remove_mask |= BrowsingDataRemover::REMOVE_CACHE; 132 remove_mask |= BrowsingDataRemover::REMOVE_CACHE;
130 if (prefs->GetBoolean(prefs::kDeleteCookies)) { 133 if (prefs->GetBoolean(prefs::kDeleteCookies)) {
131 remove_mask |= site_data_mask; 134 remove_mask |= site_data_mask;
132 origin_mask |= BrowsingDataHelper::UNPROTECTED_WEB; 135 origin_mask |= BrowsingDataHelper::UNPROTECTED_WEB;
133 } 136 }
134 if (prefs->GetBoolean(prefs::kDeletePasswords)) 137 if (prefs->GetBoolean(prefs::kDeletePasswords))
135 remove_mask |= BrowsingDataRemover::REMOVE_PASSWORDS; 138 remove_mask |= BrowsingDataRemover::REMOVE_PASSWORDS;
136 if (prefs->GetBoolean(prefs::kDeleteFormData)) 139 if (prefs->GetBoolean(prefs::kDeleteFormData))
137 remove_mask |= BrowsingDataRemover::REMOVE_FORM_DATA; 140 remove_mask |= BrowsingDataRemover::REMOVE_FORM_DATA;
138 if (prefs->GetBoolean(prefs::kDeauthorizeContentLicenses)) 141 // Clearing Content Licenses is only supported in Pepper Flash.
142 if (prefs->GetBoolean(prefs::kDeauthorizeContentLicenses) &&
143 *pepper_flash_settings_enabled_) {
139 remove_mask |= BrowsingDataRemover::REMOVE_CONTENT_LICENSES; 144 remove_mask |= BrowsingDataRemover::REMOVE_CONTENT_LICENSES;
145 }
140 if (prefs->GetBoolean(prefs::kDeleteHostedAppsData)) { 146 if (prefs->GetBoolean(prefs::kDeleteHostedAppsData)) {
141 remove_mask |= site_data_mask; 147 remove_mask |= site_data_mask;
142 origin_mask |= BrowsingDataHelper::PROTECTED_WEB; 148 origin_mask |= BrowsingDataHelper::PROTECTED_WEB;
143 } 149 }
144 150
145 // BrowsingDataRemover deletes itself when done. 151 // BrowsingDataRemover deletes itself when done.
146 int period_selected = prefs->GetInteger(prefs::kDeleteTimePeriod); 152 int period_selected = prefs->GetInteger(prefs::kDeleteTimePeriod);
147 remover_ = BrowsingDataRemover::CreateForPeriod(profile, 153 remover_ = BrowsingDataRemover::CreateForPeriod(profile,
148 static_cast<BrowsingDataRemover::TimePeriod>(period_selected)); 154 static_cast<BrowsingDataRemover::TimePeriod>(period_selected));
149 remover_->AddObserver(this); 155 remover_->AddObserver(this);
150 remover_->Remove(remove_mask, origin_mask); 156 remover_->Remove(remove_mask, origin_mask);
151 } 157 }
152 158
153 void ClearBrowserDataHandler::OnBrowsingDataRemoverDone() { 159 void ClearBrowserDataHandler::OnBrowsingDataRemoverDone() {
154 // No need to remove ourselves as an observer as BrowsingDataRemover deletes 160 // No need to remove ourselves as an observer as BrowsingDataRemover deletes
155 // itself after we return. 161 // itself after we return.
156 remover_ = NULL; 162 remover_ = NULL;
157 web_ui()->CallJavascriptFunction("ClearBrowserDataOverlay.doneClearing"); 163 web_ui()->CallJavascriptFunction("ClearBrowserDataOverlay.doneClearing");
158 } 164 }
159 165
160 } // namespace options 166 } // namespace options
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/options/clear_browser_data_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698