Issue 10996018: Allow partial scanning of large arrays in order to avoid

Issue 10996018: Allow partial scanning of large arrays in order to avoid (Closed)

Created:
8 years, 2 months ago by Erik Corry

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Allow partial scanning of large arrays in order to avoid mark stack overflow. This is a reland of r12609 - https://chromiumcodereview.appspot.com/10959011 - but this time VisitPointers has been fixed (it used to assume that the first slot was on the first page of a large object). Committed: https://code.google.com/p/v8/source/detail?r=12619

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+376 lines, -121 lines)			Patch
M	src/heap.cc	View	1 2 3	4 chunks	+15 lines, -13 lines	0 comments	Download
M	src/incremental-marking.cc	View	1 2 3	6 chunks	+157 lines, -61 lines	0 comments	Download
M	src/mark-compact.h	View		2 chunks	+33 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1 2 3	13 chunks	+106 lines, -30 lines	0 comments	Download
M	src/mark-compact-inl.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/objects-visiting.h	View	1 2 3	2 chunks	+8 lines, -3 lines	0 comments	Download
M	src/objects-visiting-inl.h	View	1 2 3	3 chunks	+16 lines, -9 lines	0 comments	Download
M	src/spaces.h	View		4 chunks	+37 lines, -2 lines	0 comments	Download
M	src/spaces.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a few comments). https://chromiumcodereview.appspot.com/10996018/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/10996018/diff/1/src/mark-compact.cc#newcode2195 src/mark-compact.cc:2195: void MarkCompactCollector::ProcessLargePostponedArrays(Heap* heap, Just ...

8 years, 2 months ago (2012-09-26 11:40:06 UTC) #2

Erik Corry

8 years, 2 months ago (2012-09-26 11:42:20 UTC) #3

https://chromiumcodereview.appspot.com/10996018/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/10996018/diff/1/src/mark-compact.cc#ne...
src/mark-compact.cc:2195: void
MarkCompactCollector::ProcessLargePostponedArrays(Heap* heap,
On 2012/09/26 11:40:07, Michael Starzinger wrote:
> Just make this non-static and you don't need to pass any arguments.

The incremental marker also uses it, to avoid code duplication.

Expand Messages | Collapse Messages