Issue 10959011: Allow partial scanning of large arrays in order to avoid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10959011: Allow partial scanning of large arrays in order to avoid (Closed)

Created:
8 years, 3 months ago by Erik Corry

Modified:
8 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Allow partial scanning of large arrays in order to avoid mark stack overflow. Committed: https://code.google.com/p/v8/source/detail?r=12609

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+301 lines, -72 lines)			Patch
M	src/incremental-marking.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/incremental-marking.cc	View	5 chunks	+155 lines, -57 lines	0 comments	Download
M	src/mark-compact.h	View	2 chunks	+33 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	5 chunks	+77 lines, -10 lines	2 comments	Download
M	src/spaces.h	View	4 chunks	+33 lines, -2 lines	0 comments	Download
M	src/spaces.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 3 months ago (2012-09-20 13:29:48 UTC) #2

Two general questions on the incremental marking part of this CL:

1) Would it be possible to share the code between incremental and
non-incremental marking?
2) Would it be possible to use static visitors for incremental marking?

https://codereview.chromium.org/10959011/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/10959011/diff/1/src/mark-compact.cc#newcode2181
src/mark-compact.cc:2181: } while (!marking_deque_.IsEmpty());
Instead of adding yet another loop we could just reuse the outer one that was
added for the WeakMaps fix-point iteration.

https://codereview.chromium.org/10959011/diff/1/src/mark-compact.cc#newcode2190
src/mark-compact.cc:2190: void
MarkCompactCollector::FillMarkingDequeFromLargePostponedArrays() {
How about naming this "ProcessLargePostponedArrays()"

Expand Messages | Collapse Messages