Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc

Issue 10993089: Upstream Android implementation of WebContentsViewDelegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc
diff --git a/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc b/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc
index 6340072ab17816e02d696f4872e05a1468e07d0f..2718bcc57585cdc16753bcc46903b7737bb87a92 100644
--- a/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc
+++ b/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc
@@ -28,10 +28,15 @@ ChromeWebContentsViewDelegateAndroid::GetDragDestDelegate() {
void ChromeWebContentsViewDelegateAndroid::ShowContextMenu(
const content::ContextMenuParams& params,
content::ContextMenuSourceType type) {
- // http://crbug.com/136075
- NOTIMPLEMENTED();
- // Still lacking some code here that depends on
- // content/public/browser/android/content_view_core.h
+ // So we instruct the ContentView to select the text directly.
+ if (params.is_editable && !params.selection_text.empty()) {
+ content::ContentViewCore* content_view_core =
+ web_contents_->GetContentNativeView();
+ if (content_view_core) {
+ content_view_core->SelectText(params.selection_text, params.x, params.y);
+ return;
+ }
+ }
TabAndroid* tab = TabAndroid::FromWebContents(web_contents_);
// We may not have a Tab if we're running in Android WebView mode.

Powered by Google App Engine
This is Rietveld 408576698