content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 10993089: Upstream Android implementation of WebContentsViewDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 10993089: Upstream Android implementation of WebContentsViewDelegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_view_core_impl.cc ('k') | content/public/android/java/src/org/chromium/content/browser/InsertionHandleController.java » ('j') | content/public/android/java/src/org/chromium/content/browser/InsertionHandleController.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 49513764f448caa89147240b87fa99d4138724de..3b2ad282733eedc8fae5d58350fca076b2b80b3e 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1345,6 +1345,15 @@ public class ContentViewCore implements MotionEventDelegate {

getContentViewClient().onEvaluateJavaScriptResult(id, jsonResult);

}

+ @SuppressWarnings("unused")

+ @CalledByNative

+ private void onTextSelected(String selected_text, int selectionStartX,

+ int selectionStartY) {

nilesh 2012/09/29 01:04:07 line break before "int selectionStartX "

+ getInsertionHandleController().showHandleWithPastePopupAt(

+ selectionStartX - mNativeScrollX,

+ selectionStartY - mNativeScrollY);

nilesh 2012/09/29 01:04:07 will this fit on line 1354?

+ }

/**

* @return Whether a reload happens when this ContentView is activated.