Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Issue 10990078: Cleanup: Use plugin constants in more places. (Closed)

Created:
8 years, 2 months ago by Lei Zhang
Modified:
8 years, 2 months ago
Reviewers:
Bernhard Bauer, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Cleanup: Use plugin constants in more places. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159133

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M chrome/browser/chrome_plugin_browsertest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/version_handler.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 4 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
8 years, 2 months ago (2012-09-27 05:02:12 UTC) #1
Bernhard Bauer
LGTM, thanks!
8 years, 2 months ago (2012-09-27 05:34:06 UTC) #2
Lei Zhang
piman: content OWNERS review please.
8 years, 2 months ago (2012-09-27 20:14:13 UTC) #3
piman
lgtm
8 years, 2 months ago (2012-09-27 20:15:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10990078/4002
8 years, 2 months ago (2012-09-27 20:18:15 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/browser/policy/policy_browsertest.cc: While running patch -p0 --forward --force; patching file chrome/browser/policy/policy_browsertest.cc ...
8 years, 2 months ago (2012-09-27 20:18:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10990078/11009
8 years, 2 months ago (2012-09-27 20:27:43 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-09-27 22:11:59 UTC) #8
Change committed as 159133

Powered by Google App Engine
This is Rietveld 408576698