Cleanup: Use plugin constants in more places.

chrome/browser/chrome_plugin_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/plugins/plugin_prefs.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/browser_child_process_host_iterator.h"
 #include "content/public/browser/child_process_data.h"
 #include "content/public/browser/plugin_service.h"
 #include "content/public/common/content_paths.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #include "net/base/net_util.h"
+#include "webkit/plugins/plugin_constants.h"
 #include "webkit/plugins/webplugininfo.h"
 
 using content::BrowserThread;
 
 class ChromePluginTest : public InProcessBrowserTest {
  protected:
   ChromePluginTest() {}
 
   static GURL GetURL(const char* filename) {
     FilePath path;
@@ skipping 21 matching lines @@
         BrowserThread::IO,
         FROM_HERE,
         base::Bind(&CrashFlashInternal, runner->QuitClosure()));
     runner->Run();
   }
 
   static FilePath GetFlashPath() {
     std::vector<webkit::WebPluginInfo> plugins = GetPlugins();
     for (std::vector<webkit::WebPluginInfo>::const_iterator it =
            plugins.begin(); it != plugins.end(); ++it) {
-      if (it->name == ASCIIToUTF16("Shockwave Flash"))
+      if (it->name == ASCIIToUTF16(kFlashPluginName))
         return it->path;
     }
     return FilePath();
   }
 
   static std::vector<webkit::WebPluginInfo> GetPlugins() {
     std::vector<webkit::WebPluginInfo> plugins;
     scoped_refptr<content::MessageLoopRunner> runner =
         new content::MessageLoopRunner;
     content::PluginService::GetInstance()->GetPlugins(
@@ skipping 136 matching lines @@
   std::vector<webkit::WebPluginInfo> plugins = GetPlugins();
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(expected); ++i) {
     size_t j = 0;
     for (; j < plugins.size(); ++j) {
       if (plugins[j].name == ASCIIToUTF16(expected[i]))
         break;
     }
     ASSERT_TRUE(j != plugins.size()) << "Didn't find " << expected[i];
   }
 }