Grant popup blocker bypass based upon extension context type.

Grant popup blocker bypass based upon extension context type.

BUG=117446
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158864

[Aaron Boodman, 2012-09-25 21:42:57]

lgtm w/ nit

http://codereview.chromium.org/10990038/diff/1/chrome/renderer/chrome_content...
File chrome/renderer/chrome_content_renderer_client.cc (right):

http://codereview.chromium.org/10990038/diff/1/chrome/renderer/chrome_content...
chrome/renderer/chrome_content_renderer_client.cc:729:
current_context->context_type() != extensions::Feature::WEB_PAGE_CONTEXT;
A whitelist would be better. == BLESSED_EXTENSION_CONTEXT || ==
CONTENT_SCRIPT_CONTEXT?

[Tom Sepez, 2012-09-25 22:55:35]

On 2012/09/25 21:42:57, Aaron Boodman wrote:
> lgtm w/ nit
> 
>
http://codereview.chromium.org/10990038/diff/1/chrome/renderer/chrome_content...
> File chrome/renderer/chrome_content_renderer_client.cc (right):
> 
>
http://codereview.chromium.org/10990038/diff/1/chrome/renderer/chrome_content...
> chrome/renderer/chrome_content_renderer_client.cc:729:
> current_context->context_type() != extensions::Feature::WEB_PAGE_CONTEXT;
> A whitelist would be better. == BLESSED_EXTENSION_CONTEXT || ==
> CONTENT_SCRIPT_CONTEXT?
Done.

Also test can't use the value of *ptr().

[Tom Sepez, 2012-09-25 22:56:23]

Adding jam for OWNER.

[jam, 2012-09-25 23:32:55]

please see the comment in src/chrome/OWNERS; I'm too overloaded with content
reviews to do chrome ones

[Tom Sepez, 2012-09-25 23:34:52]

Adding Nico as OWNER.

[Nico, 2012-09-26 03:01:36]

lgtm

[commit-bot: I haz the power, 2012-09-26 17:00:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/10990038/10001

[commit-bot: I haz the power, 2012-09-26 19:59:16]

Change committed as 158864