Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7053)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 10990038: Grant popup blocker bypass based upon extension context type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/app_process_apitest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
===================================================================
--- chrome/renderer/chrome_content_renderer_client.cc (revision 158606)
+++ chrome/renderer/chrome_content_renderer_client.cc (working copy)
@@ -725,7 +725,11 @@
bool ChromeContentRendererClient::AllowPopup(const GURL& creator) {
extensions::ChromeV8Context* current_context =
extension_dispatcher_->v8_context_set().GetCurrent();
- return current_context && current_context->extension();
+ return current_context && current_context->extension() &&
+ (current_context->context_type() ==
+ extensions::Feature::BLESSED_EXTENSION_CONTEXT ||
+ current_context->context_type() ==
+ extensions::Feature::CONTENT_SCRIPT_CONTEXT);
}
bool ChromeContentRendererClient::ShouldFork(WebFrame* frame,
« no previous file with comments | « chrome/browser/extensions/app_process_apitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698