Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: runtime/vm/compiler.cc

Issue 10989077: Run canonicalization again after constant propagation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler.cc » ('j') | runtime/vm/flow_graph_compiler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index d462881fee0e42a6bd6c5c80b6260677ed23481b..69e579e552e783a0a900e0285c1d792b14a5a549 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -209,6 +209,8 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
}
if (FLAG_constant_propagation) {
ConstantPropagator::Optimize(flow_graph);
+ // A canonicalization pass to remove e.g. smi checks on smi constants.
+ optimizer.OptimizeComputations();
}
if (FLAG_common_subexpression_elimination) {
DominatorBasedCSE::Optimize(flow_graph);
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler.cc » ('j') | runtime/vm/flow_graph_compiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698