runtime/vm/flow_graph_compiler.cc - Issue 10989077: Run canonicalization again after constant propagation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 10989077: Run canonicalization again after constant propagation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler.cc

diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc

index f91eb1167bee3662660f60cd2f6b75c4e141841f..716d7e326211bb1961e3b618b5b427399d0dab01 100644

--- a/runtime/vm/flow_graph_compiler.cc

+++ b/runtime/vm/flow_graph_compiler.cc

@@ -204,9 +204,9 @@ bool FlowGraphCompiler::CanOptimize() {

void FlowGraphCompiler::VisitBlocks() {

for (intptr_t i = 0; i < block_order().length(); ++i) {

- assembler()->Comment("B%"Pd"", i);

// Compile the block entry.

BlockEntryInstr* entry = block_order()[i];

+ assembler()->Comment("B%"Pd"", entry->block_id());

Florian Schneider 2012/10/02 13:08:32 Thanks for fixing this.

set_current_block(entry);

entry->PrepareEntry(this);

// Compile all successors until an exit, branch, or a block entry.

« no previous file with comments | « runtime/vm/compiler.cc ('k') | no next file » | no next file with comments »