Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 10989028: cc: Remove WebCore dependecies from CCRenderPass and CCDrawQuad classes. (Closed)

Created:
8 years, 2 months ago by danakj
Modified:
8 years, 2 months ago
Reviewers:
jamesr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, backer, piman, aelias_OOO_until_Jul13, shawnsingh
Visibility:
Public.

Description

cc: Remove WebCore dependecies from CCRenderPass and CCDrawQuad classes. We Replace geometry types such as IntRect, FloatRect etc to Web geometry, and use chromium versions of macros in the header files. R=enne,jamesr BUG=152337

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -154 lines) Patch
M cc/CCCheckerboardDrawQuad.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCCheckerboardDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCDebugBorderDrawQuad.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCDebugBorderDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCDelegatedRendererLayerImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M cc/CCDirectRenderer.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M cc/CCDrawQuad.h View 4 chunks +11 lines, -11 lines 0 comments Download
M cc/CCDrawQuad.cpp View 2 chunks +11 lines, -5 lines 0 comments Download
M cc/CCIOSurfaceDrawQuad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCIOSurfaceDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCLayerTreeHostCommonTest.cpp View 12 chunks +17 lines, -17 lines 0 comments Download
M cc/CCLayerTreeHostImpl.cpp View 6 chunks +15 lines, -9 lines 0 comments Download
M cc/CCLayerTreeHostImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCRenderPass.h View 6 chunks +17 lines, -12 lines 0 comments Download
M cc/CCRenderPass.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/CCRenderPassDrawQuad.h View 3 chunks +4 lines, -5 lines 0 comments Download
M cc/CCRenderPassDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCRenderPassTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCRendererGL.cpp View 11 chunks +24 lines, -19 lines 0 comments Download
M cc/CCRendererGLTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCRendererSoftware.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
cc/CCRendererSoftwareTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCSharedQuadState.h View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/CCSharedQuadState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCSolidColorDrawQuad.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCSolidColorDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCStreamVideoDrawQuad.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCStreamVideoDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCTextureDrawQuad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCTextureDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCTileDrawQuad.h View 3 chunks +8 lines, -8 lines 0 comments Download
M cc/CCTileDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCTiledLayerImpl.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
cc/CCYUVVideoDrawQuad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCYUVVideoDrawQuad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/scoped_ptr_hash_map.h View 1 chunk +3 lines, -2 lines 2 comments Download
M cc/stubs/FloatPoint.h View 2 chunks +10 lines, -0 lines 0 comments Download
M cc/stubs/FloatRect.h View 2 chunks +17 lines, -0 lines 0 comments Download
M cc/stubs/IntPoint.h View 2 chunks +10 lines, -0 lines 0 comments Download
M cc/stubs/IntRect.h View 2 chunks +10 lines, -0 lines 0 comments Download
M cc/stubs/IntSize.h View 2 chunks +11 lines, -0 lines 0 comments Download
M cc/test/CCGeometryTestUtils.h View 2 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danakj
PTAL. This depends on https://codereview.chromium.org/10989026/
8 years, 2 months ago (2012-09-25 23:58:00 UTC) #1
jamesr
Hmm, is this so we can serialize using the IPC macros or as a general ...
8 years, 2 months ago (2012-09-26 00:00:21 UTC) #2
danakj
8 years, 2 months ago (2012-09-26 00:03:50 UTC) #3
Right, the idea was so that I can move forward with making param_traits for a
WebCompositorFrame in content/. I agree moving to Web* isn't really a step
forward, but it is something that I can include from content/ and keep moving on
ubercomp. Shawn is working on new geometry types for cc, and we can switch from
Web* to those once he's done that, but I was hoping to unblock myself from that.

https://codereview.chromium.org/10989028/diff/1/cc/scoped_ptr_hash_map.h
File cc/scoped_ptr_hash_map.h (right):

https://codereview.chromium.org/10989028/diff/1/cc/scoped_ptr_hash_map.h#newc...
cc/scoped_ptr_hash_map.h:125: inline std::pair<const_iterator, const_iterator>
equal_range(
On 2012/09/26 00:00:21, jamesr wrote:
> hah, whoops! guessing this just wasn't referenced before so it compiled fine
> even though the type was wrong?

I think removing some header that was using std::pair maybe. But yeh, I added it
to the original CL.

Powered by Google App Engine
This is Rietveld 408576698