Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 10985073: Fixed flakiness of the PolicyTest.Javascript browser_test. (Closed)

Created:
8 years, 2 months ago by Joao da Silva
Modified:
8 years, 2 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews
Visibility:
Public.

Description

Fixed flakiness of the PolicyTest.Javascript browser_test. The chrome://settings page does navigations that confuses the observer of NAVIGATION_LOAD_STOP. BUG=143637 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Joao da Silva
Here's another test that flakes because the URL used does navigations. In this case, chrome://settings ...
8 years, 2 months ago (2012-09-28 09:32:59 UTC) #1
pastarmovj
lgtm
8 years, 2 months ago (2012-09-28 12:05:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10985073/1
8 years, 2 months ago (2012-09-28 12:09:49 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-09-28 14:22:18 UTC) #4
Change committed as 159252

Powered by Google App Engine
This is Rietveld 408576698