Chromium Code Reviews
Help | Chromium Project | Sign in
(634)

Issue 10984057: Replace a set of Hydrogen instructions with rotate instructions on ARM (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by Jay Conrod
Modified:
1 year, 5 months ago
CC:
v8-dev_googlegroups.com, hans
Visibility:
Public.

Description

Replace a set of Hydrogen instructions with rotate instructions on ARM
BUG=none
TEST=none

Patch Set 1 #

Total comments: 13

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -1 line) Lint Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M src/arm/lithium-arm.cc View 1 2 chunks +6 lines, -0 lines 0 comments 0 errors Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +10 lines, -0 lines 0 comments 0 errors Download
M src/arm/simulator-arm.cc View 1 1 chunk +8 lines, -1 line 0 comments 0 errors Download
M src/flag-definitions.h View 1 1 chunk +2 lines, -0 lines 0 comments 1 errors Download
M src/hydrogen.h View 1 2 chunks +3 lines, -0 lines 0 comments 0 errors Download
M src/hydrogen.cc View 1 2 chunks +98 lines, -0 lines 0 comments 1 errors Download
M src/hydrogen-instructions.h View 1 2 chunks +21 lines, -0 lines 0 comments 0 errors Download
M src/ia32/lithium-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments 0 errors Download
M src/token.h View 1 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M src/x64/lithium-x64.cc View 1 chunk +6 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 6
Erik Corry
http://codereview.chromium.org/10984057/diff/1/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/10984057/diff/1/src/arm/simulator-arm.cc#newcode1504 src/arm/simulator-arm.cc:1504: int32_t left = result >> shift_amount; How does this ...
1 year, 6 months ago #1
ulan
http://codereview.chromium.org/10984057/diff/1/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/10984057/diff/1/src/arm/simulator-arm.cc#newcode1507 src/arm/simulator-arm.cc:1507: *carry_out = false; The carry_out should contain the last ...
1 year, 6 months ago #2
ulan
http://codereview.chromium.org/10984057/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/10984057/diff/1/src/hydrogen.cc#newcode3539 src/hydrogen.cc:3539: #if defined(V8_TARGET_ARCH_ARM) I am concerned with this ifdef. Hydrogen ...
1 year, 6 months ago #3
Michael Starzinger
Some general high-level observations about this change: 1) This is a very specialized optimization targeting ...
1 year, 6 months ago #4
Jay Conrod
On 2012/09/27 23:53:27, Michael Starzinger wrote: > Some general high-level observations about this change: > ...
1 year, 6 months ago #5
ulan
1 year, 6 months ago #6
Hi Jay,

While waiting for the new revision of this patch set, I started prototyping
implementation of ROR for ia32 and x64 architectures, so that we can get rid of
the ARM specific #ifdef in hydrogen.cc.

You can review the CL at https://chromiumcodereview.appspot.com/11033005/

Once you upload new patch set, we can combine both CLs to get something in
landable state.

I also added some tests and moved detection of the ROR pattern to the visitor of
the bitwise OR. This seems cleaner to me than adding a new hydrogen phase just
to detect one specific pattern, WDYT?

Please note that I checked the generated code but didn't check performance on
StringSHA1 yet. How can I do this?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6