Issue 10984047: Revert 158513 - Maybe fix InstantTest.NewWindowDismissesInstant on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10984047: Revert 158513 - Maybe fix InstantTest.NewWindowDismissesInstant on Mac. (Closed)

Created:
8 years, 2 months ago by sreeram

Modified:
8 years, 2 months ago

Reviewers:
jennb

CC:
chromium-reviews, samarth, sreeram, gideonwald, dominich, David Black, Jered, Shishir

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert 158513 - Maybe fix InstantTest.NewWindowDismissesInstant on Mac. The test still fails (see review thread for log link), even after the attempted fix, so revert it. See bug for possible true cause. BUG=152461 R=jennb@chromium.org TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158869

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/browser/instant/instant_browsertest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sreeram

Please review. The test still fails: http://chromium-build-logs.appspot.com/viewlog/raw/AMIfv95tJ8s-pAN7UwwsoRKIrFx3vWCK8jFK4kZudtPhG4eUU1kGxMOu8YfEuQkALHh76U7CPrIgKPFEdTw2EGM78FiOjIrikGq_rw51rIQJpU2S45-FlHKN0l_d3S3q4Ml4s_nTsqVGTnHsjbaot6G22zEHh1m93Pk5_qjvGBP3MpIi7Os4PFU

8 years, 2 months ago (2012-09-26 17:42:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sreeram@chromium.org/10984047/1

8 years, 2 months ago (2012-09-26 17:57:44 UTC) #3

Change committed as 158869

Expand Messages | Collapse Messages