Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 10984047: Revert 158513 - Maybe fix InstantTest.NewWindowDismissesInstant on Mac. (Closed)

Created:
8 years, 2 months ago by sreeram
Modified:
8 years, 2 months ago
Reviewers:
jennb
CC:
chromium-reviews, samarth, sreeram, gideonwald, dominich, David Black, Jered, Shishir
Visibility:
Public.

Description

Revert 158513 - Maybe fix InstantTest.NewWindowDismissesInstant on Mac. The test still fails (see review thread for log link), even after the attempted fix, so revert it. See bug for possible true cause. BUG=152461 R=jennb@chromium.org TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/instant/instant_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sreeram
Please review. The test still fails: http://chromium-build-logs.appspot.com/viewlog/raw/AMIfv95tJ8s-pAN7UwwsoRKIrFx3vWCK8jFK4kZudtPhG4eUU1kGxMOu8YfEuQkALHh76U7CPrIgKPFEdTw2EGM78FiOjIrikGq_rw51rIQJpU2S45-FlHKN0l_d3S3q4Ml4s_nTsqVGTnHsjbaot6G22zEHh1m93Pk5_qjvGBP3MpIi7Os4PFU
8 years, 2 months ago (2012-09-26 17:42:15 UTC) #1
jennb
LGTM I see. sniff.
8 years, 2 months ago (2012-09-26 17:47:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sreeram@chromium.org/10984047/1
8 years, 2 months ago (2012-09-26 17:57:44 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 20:05:04 UTC) #4
Change committed as 158869

Powered by Google App Engine
This is Rietveld 408576698