chrome/browser/instant/instant_browsertest.cc - Issue 10984047: Revert 158513 - Maybe fix InstantTest.NewWindowDismissesInstant on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/instant/instant_browsertest.cc

Issue 10984047: Revert 158513 - Maybe fix InstantTest.NewWindowDismissesInstant on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/instant/instant_browsertest.cc

diff --git a/chrome/browser/instant/instant_browsertest.cc b/chrome/browser/instant/instant_browsertest.cc

index 94478ea9595900a3b75ae66c46b14b939b625eaa..a2e04cb37410ecb4689bab2b922e5e81ab4e7877 100644

--- a/chrome/browser/instant/instant_browsertest.cc

+++ b/chrome/browser/instant/instant_browsertest.cc

@@ -821,7 +821,6 @@ IN_PROC_BROWSER_TEST_F(InstantTest, History) {

IN_PROC_BROWSER_TEST_F(InstantTest, NewWindowDismissesInstant) {

ASSERT_NO_FATAL_FAILURE(SetupInstant("instant.html"));

EXPECT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));

- base::RunLoop().RunUntilIdle();

SetOmniboxTextAndWaitForInstantToShow("search");

Browser* previous_window = browser();

« no previous file with comments | « no previous file | no next file » | no next file with comments »