Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10983045: NTP5: Adjusting dynamic padding implementation. (Closed)

Created:
8 years, 2 months ago by pedro (no code reviews)
Modified:
8 years, 2 months ago
Reviewers:
csilv
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

NTP5: Adjusting dynamic padding implementation. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158901

Patch Set 1 #

Patch Set 2 : Syncing and rebading #

Patch Set 3 : Syncing and rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/ntp_search/tile_page.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
pedro (no code reviews)
Hey Chris, as we spoke offline, this CL complements the other one that was submitted ...
8 years, 2 months ago (2012-09-26 18:12:27 UTC) #1
csilv
lgtm
8 years, 2 months ago (2012-09-26 18:13:51 UTC) #2
pedro (no code reviews)
Thanks a lot!
8 years, 2 months ago (2012-09-26 18:14:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/10983045/1
8 years, 2 months ago (2012-09-26 18:15:33 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-09-26 18:34:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/10983045/4
8 years, 2 months ago (2012-09-26 18:49:10 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 21:46:58 UTC) #7 
Change committed as 158901

Powered by Google App Engine
This is Rietveld 408576698