Issue 10983004: Fix warnings when compiling with clang

Issue 10983004: Fix warnings when compiling with clang (Closed)

Created:
8 years, 3 months ago by michaelbai

Modified:
8 years, 2 months ago

Reviewers:
joth, Yaron, qinmin, scherkus (not reviewing)

CC:
qinmin, chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, feature-media-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix warnings when compiling with clang TBR=scherkus BUG=143931 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158493

Patch Set 3 : Remove the include #

Patch Set 4 : Sync try #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -12 lines)			Patch
M	android_webview/lib/aw_browser_dependency_factory_impl.h	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
M	android_webview/lib/aw_browser_dependency_factory_impl.cc	View	1 2	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/browser/android/cookie_getter_impl.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	content/renderer/media/webmediaplayer_proxy_impl_android.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/android/media_player_bridge.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

michaelbai

Joth@ for android_webview Yaron for content/browser/android scherkus@ for content/render and media/base

8 years, 3 months ago (2012-09-24 21:17:51 UTC) #1

qinmin

lgtm. Sorry, I have a downstream patch that fixes all the clang errors, but haven't ...

8 years, 3 months ago (2012-09-24 21:19:51 UTC) #2

joth

NACK http://codereview.chromium.org/10983004/diff/1/android_webview/lib/aw_browser_dependency_factory_impl.h File android_webview/lib/aw_browser_dependency_factory_impl.h (right): http://codereview.chromium.org/10983004/diff/1/android_webview/lib/aw_browser_dependency_factory_impl.h#newcode34 android_webview/lib/aw_browser_dependency_factory_impl.h:34: virtual content::JavaScriptDialogCreator* GetJavaScriptDialogCreator(); this must indicate a bug. ...

8 years, 3 months ago (2012-09-24 21:39:46 UTC) #4

Yaron

http://codereview.chromium.org/10983004/diff/1/android_webview/lib/aw_browser_dependency_factory_impl.h File android_webview/lib/aw_browser_dependency_factory_impl.h (right): http://codereview.chromium.org/10983004/diff/1/android_webview/lib/aw_browser_dependency_factory_impl.h#newcode34 android_webview/lib/aw_browser_dependency_factory_impl.h:34: virtual content::JavaScriptDialogCreator* GetJavaScriptDialogCreator(); On 2012/09/24 21:39:46, joth wrote: > ...

8 years, 3 months ago (2012-09-24 21:42:28 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10983004/7001

8 years, 3 months ago (2012-09-24 22:07:34 UTC) #6

joth

lgtm but I see more cleanup potential :) http://codereview.chromium.org/10983004/diff/7001/android_webview/lib/aw_browser_dependency_factory_impl.cc File android_webview/lib/aw_browser_dependency_factory_impl.cc (right): http://codereview.chromium.org/10983004/diff/7001/android_webview/lib/aw_browser_dependency_factory_impl.cc#newcode17 android_webview/lib/aw_browser_dependency_factory_impl.cc:17: #include ...

8 years, 3 months ago (2012-09-24 23:20:01 UTC) #7

michaelbai

http://codereview.chromium.org/10983004/diff/7001/android_webview/lib/aw_browser_dependency_factory_impl.cc File android_webview/lib/aw_browser_dependency_factory_impl.cc (right): http://codereview.chromium.org/10983004/diff/7001/android_webview/lib/aw_browser_dependency_factory_impl.cc#newcode17 android_webview/lib/aw_browser_dependency_factory_impl.cc:17: #include "chrome/browser/ui/app_modal_dialogs/javascript_dialog_creator.h" On 2012/09/24 23:20:02, joth wrote: > can ...

8 years, 3 months ago (2012-09-24 23:25:55 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10983004/1005

8 years, 3 months ago (2012-09-24 23:42:31 UTC) #10

Change committed as 158493

Expand Messages | Collapse Messages