Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 10979011: Revert 158451 - Always use objdump to determine arch of nexe (Closed)

Created:
8 years, 2 months ago by Sam Clegg
Modified:
8 years, 2 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 158451 - Always use objdump to determine arch of nexe This broke chromeos builds and I'm not currently setup to build and test chromeos so revert for now. BUG= TBR=binji Review URL: https://chromiumcodereview.appspot.com/10916343 TBR=sbc@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -61 lines) Patch
M native_client_sdk/src/tools/create_nmf.py View 12 chunks +22 lines, -61 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sam Clegg
8 years, 2 months ago (2012-09-25 01:49:35 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 2 months ago (2012-09-25 01:50:50 UTC) #2
Sam Clegg
Can one of you guys LG this revert for me? The build is still broken ...
8 years, 2 months ago (2012-09-25 16:13:59 UTC) #3
bshe
On 2012/09/25 01:50:50, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
8 years, 2 months ago (2012-09-25 16:14:44 UTC) #4
davidjames
lgtm
8 years, 2 months ago (2012-09-25 16:14:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10979011/1
8 years, 2 months ago (2012-09-25 16:15:01 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-09-25 18:29:46 UTC) #7
Change committed as 158618

Powered by Google App Engine
This is Rietveld 408576698