create_nmf can now determine arch of nexe files

create_nmf now knows how to read the ELF headers
to determine the arch of nexes


BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158451

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163140

[Sam Clegg, 2012-09-17 19:03:36]

For some reason we were not using objdump to determine
arch for newlib builds, and instead relying on the nexe
name (which is bad).

[Sam Clegg, 2012-09-17 19:05:42]

On 2012/09/17 19:03:36, Sam Clegg wrote:
> For some reason we were not using objdump to determine
> arch for newlib builds, and instead relying on the nexe
> name (which is bad).

All I've done here is remove the old newlib path.  The code for
non-newlib is unchanged.. only un-indented.

[noelallen1, 2012-09-17 19:11:31]

lgtm

[binji, 2012-09-17 19:12:22]

http://codereview.chromium.org/10916343/diff/3001/native_client_sdk/src/tools...
File native_client_sdk/src/tools/create_nmf.py (left):

http://codereview.chromium.org/10916343/diff/3001/native_client_sdk/src/tools...
native_client_sdk/src/tools/create_nmf.py:225: runnable = (self.toolchain !=
'newlib' and self.toolchain != 'pnacl')
what about pnacl...?

[Sam Clegg, 2012-09-18 17:48:22]

Addressed create_nmf for pnacl builds.

Although the path to objdump is a little obscure
it seems to be the best solution for now.  The
objdump from glibc and newlib won't recognize all
the pnacl nexes.

https://chromiumcodereview.appspot.com/10916343/diff/3001/native_client_sdk/s...
File native_client_sdk/src/tools/create_nmf.py (left):

https://chromiumcodereview.appspot.com/10916343/diff/3001/native_client_sdk/s...
native_client_sdk/src/tools/create_nmf.py:225: runnable = (self.toolchain !=
'newlib' and self.toolchain != 'pnacl')
On 2012/09/17 19:12:22, binji wrote:
> what about pnacl...?

Done.

[noelallen1, 2012-09-19 19:38:59]

Have you diagnosed the pnacl failure in this CL?

[binji, 2012-09-19 19:40:19]

On 2012/09/19 19:38:59, noelallen1 wrote:
> Have you diagnosed the pnacl failure in this CL?

This is the same pnacl failure on the waterfall (due to r157462), I'm
investigating it now.

[sbc, 2012-09-19 19:51:01]

Great.. let me know when I can re-try.


On Wed, Sep 19, 2012 at 12:40 PM,  <binji@chromium.org> wrote:
> On 2012/09/19 19:38:59, noelallen1 wrote:
>>
>> Have you diagnosed the pnacl failure in this CL?
>
>
> This is the same pnacl failure on the waterfall (due to r157462), I'm
> investigating it now.
>
> http://codereview.chromium.org/10916343/

[Sam Clegg, 2012-09-24 19:20:38]

This new version doesn't require objdump except for glibc builds.

It always determines the arch of the nexe's by reading the
elf header directly.

[Sam Clegg, 2012-09-24 19:28:03]

Remove unneeded changes from this patch.

[binji, 2012-09-24 19:37:04]

much cleaner! lgtm

http://codereview.chromium.org/10916343/diff/30002/native_client_sdk/src/tool...
File native_client_sdk/src/tools/create_nmf.py (right):

http://codereview.chromium.org/10916343/diff/30002/native_client_sdk/src/tool...
native_client_sdk/src/tools/create_nmf.py:16: import struct
alphabetize

http://codereview.chromium.org/10916343/diff/30002/native_client_sdk/src/tool...
native_client_sdk/src/tools/create_nmf.py:105: def ReadElfHeader(self):
make this private.

http://codereview.chromium.org/10916343/diff/30002/native_client_sdk/src/tool...
native_client_sdk/src/tools/create_nmf.py:110: #   unsigned
char	e_ident[EI_NIDENT]; /* Magic number and other info */
kill tab

[commit-bot: I haz the power, 2012-09-24 22:04:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/10916343/43001

[commit-bot: I haz the power, 2012-09-25 00:04:51]

Change committed as 158451

[Mark Seaborn, 2012-09-25 14:57:59]

This change seems to have broken the ARM Chrome OS build, which fails with this
error:

chromeos-chrome-24.0.1277.0_alpha-r1: create_nmf.py: Not a valid NaCL
executable:
/var/cache/distfiles/target/chrome-src/src/c/Release/nacl_test_data/newlib/pm_exit_status_test_newlib_arm.nexe
chromeos-chrome-24.0.1277.0_alpha-r1: make: ***
[c/Release/nacl_test_data/newlib/pm_exit_status_test.nmf] Error 1

(see
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28dais...)

FYI, you need to test changes on the "cros_daisy" Chrome trybot to get ARM
coverage.

[sbc, 2012-09-25 16:16:34]

Thanks,

I tried to revert last night but it didn't go through, so reverting now.

BTW, that nexe apparently is an LLVM bitcode file.  Should that ever
be possible?

On Tue, Sep 25, 2012 at 7:57 AM,  <mseaborn@chromium.org> wrote:
> This change seems to have broken the ARM Chrome OS build, which fails with
> this
> error:
>
> chromeos-chrome-24.0.1277.0_alpha-r1: create_nmf.py: Not a valid NaCL
> executable:
>
/var/cache/distfiles/target/chrome-src/src/c/Release/nacl_test_data/newlib/pm_exit_status_test_newlib_arm.nexe
> chromeos-chrome-24.0.1277.0_alpha-r1: make: ***
> [c/Release/nacl_test_data/newlib/pm_exit_status_test.nmf] Error 1
>
> (see
>
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28dais...)
>
> FYI, you need to test changes on the "cros_daisy" Chrome trybot to get ARM
> coverage.
>
>
> https://chromiumcodereview.appspot.com/10916343/

[Sam Clegg, 2012-10-17 22:19:55]

This fox for chromeos has now landed so this change should
now be fine.

I'm trying on cros_daisy but it seems to be failing for other
reasons.


On 2012/09/25 16:16:34, sbc wrote:
> Thanks,
> 
> I tried to revert last night but it didn't go through, so reverting now.
> 
> BTW, that nexe apparently is an LLVM bitcode file.  Should that ever
> be possible?
> 
> On Tue, Sep 25, 2012 at 7:57 AM,  <mailto:mseaborn@chromium.org> wrote:
> > This change seems to have broken the ARM Chrome OS build, which fails with
> > this
> > error:
> >
> > chromeos-chrome-24.0.1277.0_alpha-r1: create_nmf.py: Not a valid NaCL
> > executable:
> >
>
/var/cache/distfiles/target/chrome-src/src/c/Release/nacl_test_data/newlib/pm_exit_status_test_newlib_arm.nexe
> > chromeos-chrome-24.0.1277.0_alpha-r1: make: ***
> > [c/Release/nacl_test_data/newlib/pm_exit_status_test.nmf] Error 1
> >
> > (see
> >
>
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%2520%2528...)
> >
> > FYI, you need to test changes on the "cros_daisy" Chrome trybot to get ARM
> > coverage.
> >
> >
> > https://chromiumcodereview.appspot.com/10916343/

[commit-bot: I haz the power, 2012-10-19 18:34:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/10916343/54001

[commit-bot: I haz the power, 2012-10-19 19:26:49]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-19 23:57:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/10916343/54001

[commit-bot: I haz the power, 2012-10-20 03:01:46]

Change committed as 163140