Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller.h

Issue 10969016: web intents. Fix callbacks to restore tab management on service exit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move invalidation Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/intents/web_intent_picker_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/intents/web_intent_picker_controller.h
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.h b/chrome/browser/ui/intents/web_intent_picker_controller.h
index 27a75a2533600f806fe8e7aff873f122a9512694..78d3c37b2cc718a3599e641c654715049b24985b 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller.h
+++ b/chrome/browser/ui/intents/web_intent_picker_controller.h
@@ -307,11 +307,17 @@ class WebIntentPickerController
// Request consumer used when asynchronously loading favicons.
CancelableRequestConsumerTSimple<size_t> favicon_consumer_;
+ // Factory for weak pointers used in callbacks for async calls to load the
+ // picker model.
base::WeakPtrFactory<WebIntentPickerController> weak_ptr_factory_;
// Timer factory for minimum display time of "waiting" dialog.
base::WeakPtrFactory<WebIntentPickerController> timer_factory_;
+ // Weak pointers for the dispatcher OnSendReturnMessage will not be
+ // cancelled on picker close.
+ base::WeakPtrFactory<WebIntentPickerController> dispatcher_factory_;
+
// Bucket identifier for UMA reporting. Saved off in a field
// to avoid repeated calculation of the bucket across
// multiple UMA calls. Should be recalculated each time
« no previous file with comments | « no previous file | chrome/browser/ui/intents/web_intent_picker_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698