Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: chrome/browser/ui/intents/web_intent_picker_controller.h

Issue 10969016: web intents. Fix callbacks to restore tab management on service exit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move invalidation Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/intents/web_intent_picker_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 // client page. 300 // client page.
301 content::WebIntentsDispatcher* intents_dispatcher_; 301 content::WebIntentsDispatcher* intents_dispatcher_;
302 302
303 // Weak pointer to the tab servicing the intent. Remembered in order to 303 // Weak pointer to the tab servicing the intent. Remembered in order to
304 // close it when a reply is sent. 304 // close it when a reply is sent.
305 content::WebContents* service_tab_; 305 content::WebContents* service_tab_;
306 306
307 // Request consumer used when asynchronously loading favicons. 307 // Request consumer used when asynchronously loading favicons.
308 CancelableRequestConsumerTSimple<size_t> favicon_consumer_; 308 CancelableRequestConsumerTSimple<size_t> favicon_consumer_;
309 309
310 // Factory for weak pointers used in callbacks for async calls to load the
311 // picker model.
310 base::WeakPtrFactory<WebIntentPickerController> weak_ptr_factory_; 312 base::WeakPtrFactory<WebIntentPickerController> weak_ptr_factory_;
311 313
312 // Timer factory for minimum display time of "waiting" dialog. 314 // Timer factory for minimum display time of "waiting" dialog.
313 base::WeakPtrFactory<WebIntentPickerController> timer_factory_; 315 base::WeakPtrFactory<WebIntentPickerController> timer_factory_;
314 316
317 // Weak pointers for the dispatcher OnSendReturnMessage will not be
318 // cancelled on picker close.
319 base::WeakPtrFactory<WebIntentPickerController> dispatcher_factory_;
320
315 // Bucket identifier for UMA reporting. Saved off in a field 321 // Bucket identifier for UMA reporting. Saved off in a field
316 // to avoid repeated calculation of the bucket across 322 // to avoid repeated calculation of the bucket across
317 // multiple UMA calls. Should be recalculated each time 323 // multiple UMA calls. Should be recalculated each time
318 // |intents_dispatcher_| is set. 324 // |intents_dispatcher_| is set.
319 web_intents::UMABucket uma_bucket_; 325 web_intents::UMABucket uma_bucket_;
320 326
321 DISALLOW_COPY_AND_ASSIGN(WebIntentPickerController); 327 DISALLOW_COPY_AND_ASSIGN(WebIntentPickerController);
322 }; 328 };
323 329
324 #endif // CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_ 330 #endif // CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/intents/web_intent_picker_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698