Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 10966044: Properly process dart:core classes if dart:core is imported with prefix. (Closed)

Created:
8 years, 3 months ago by Anton Muhin
Modified:
8 years, 3 months ago
Reviewers:
Roman
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly process dart:core classes if dart:core is imported with prefix. In this case we force prefix omission. However, there is a twist: when visit prefix.name form in send visitor later, we cannot tell it from dynamic invocation and hence to play safe we add platform libs class name to the set of forbidden names. Also, most probably we need a proper support for top-level from dart:core. R=smok@google.com BUG=5345 Committed: https://code.google.com/p/dart/source/detail?r=12766

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M lib/compiler/implementation/dart_backend/backend.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download
M lib/compiler/implementation/dart_backend/placeholder_collector.dart View 1 1 chunk +15 lines, -10 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anton Muhin
8 years, 3 months ago (2012-09-21 19:30:17 UTC) #1
Roman
lgtm https://chromiumcodereview.appspot.com/10966044/diff/1/lib/compiler/implementation/dart_backend/placeholder_collector.dart File lib/compiler/implementation/dart_backend/placeholder_collector.dart (right): https://chromiumcodereview.appspot.com/10966044/diff/1/lib/compiler/implementation/dart_backend/placeholder_collector.dart#newcode454 lib/compiler/implementation/dart_backend/placeholder_collector.dart:454: if (type.element !== compiler.types.dynamicType.element) { please add a ...
8 years, 3 months ago (2012-09-24 09:32:53 UTC) #2
Anton Muhin
8 years, 3 months ago (2012-09-24 10:09:37 UTC) #3
Thanks a lot for review, Roma.

https://chromiumcodereview.appspot.com/10966044/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/10966044/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:454: if
(type.element !== compiler.types.dynamicType.element) {
On 2012/09/24 09:32:53, Roman wrote:
> please add a comment about mycore.Dynamic, mycore.print

Done.

Powered by Google App Engine
This is Rietveld 408576698